Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input for NodeJS distribution url #1150

Open
petercort opened this issue Oct 24, 2024 · 3 comments
Open

Add input for NodeJS distribution url #1150

petercort opened this issue Oct 24, 2024 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@petercort
Copy link

Description:
Add an input named distribution-url which would set the URL where the specified nodejs dist is downloaded from.

Justification:

  1. Periodically using the default NodeJS download url fails causing jobs to fail and it would be nice to point to a custom mirror.
  2. Security and network isolation concerns related to private packages apply to the node dist itself as well.

Are you willing to submit a PR?
Yes!

@petercort petercort added feature request New feature or request to improve the current logic needs triage labels Oct 24, 2024
@priyagupta108
Copy link
Contributor

Hi @petercort 👋 ,
Thank you for the feature request, We'll investigate it and get back to you with updates.

@decyjphr
Copy link

@priyagupta108 Any update on this.

Also for documentation purposes, here is the ask in customer's words (Peter has already distilled this accurately above):

  • We've been having a noticeable issue with nodejs.org timing out while trying to download a particular distribution of node. We've historically experienced a similar issue on our legacy (bamboo & jenkins) pipelines - So it's fairly apparently it's not actually an actions issue.
    We solved it in legacy by mirroring the nodejs repository in our internal Artifactory instance. We'd like to do this in actions as well, however the actions/setup-node code has nodejs.org hardcoded as the download url: https://github.com/actions/setup-node/blob/main/src/distributions/official_builds/official_builds.ts#L179-L181
    We were considering opening a pull request against the action to allow something along the lines of an NODEJS_REPOSITORY_URL override variable to allow a custom mirror. It would also need to be able to present credentials to that registry.

@enyil
Copy link

enyil commented Dec 2, 2024

I believe the easiest way would be to merge this PR: #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants