New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overgrowing of the toolchains.xml on the self-hosted runners #530
Labels
bug
Something isn't working
Comments
Okeanos
added a commit
to Okeanos/setup-java
that referenced
this issue
Sep 19, 2023
On self-hosted runners toolchains.xml may survive multiple runs and unexpectedly grow as a result of the toolchains setup simply appending the JDK definition even if one with the same `type` and `provides.id` already exists. Restructuring the parsing step and filtering the potentially existing list of toolchain definitions prevents this and also fixes toolchain.xml files that already contain duplicates. Fixes actions#530
2 tasks
2 tasks
Okeanos
added a commit
to Okeanos/setup-java
that referenced
this issue
Nov 29, 2023
On self-hosted runners toolchains.xml may survive multiple runs and unexpectedly grow as a result of the toolchains setup simply appending the JDK definition even if one with the same `type` and `provides.id` already exists. Restructuring the parsing step and filtering the potentially existing list of toolchain definitions prevents this and also fixes toolchain.xml files that already contain duplicates. Fixes actions#530
Okeanos
added a commit
to Okeanos/setup-java
that referenced
this issue
Dec 9, 2023
On self-hosted runners toolchains.xml may survive multiple runs and unexpectedly grow as a result of the toolchains setup simply appending the JDK definition even if one with the same `type` and `provides.id` already exists. Restructuring the parsing step and filtering the potentially existing list of toolchain definitions prevents this and also fixes toolchain.xml files that already contain duplicates. Fixes actions#530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Every time build runs setup-java adds a new toolchain element to toolchains.xml. Even it already exists.
Thanks @cyrillzadra for mentioning this issue.
Task version:
v3
Platform:
Runner type:
Repro steps:
Run actions several times in a row and check the
toolchains.xml
file.Expected behavior:
The
toolchains.xml
should have only none identical toolchains records.Actual behavior:
The
toolchains.xml
has several (in relation to number of action runs) identical toolchains records.The text was updated successfully, but these errors were encountered: