Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Block on unknown licenses #732

Closed
austimkelly opened this issue Mar 27, 2024 · 1 comment
Closed

Feature Request: Block on unknown licenses #732

austimkelly opened this issue Mar 27, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austimkelly
Copy link

Split from: #714

Summary: There's no way to block an unknown license. This would be ideal because you run the risk of introducing copy-left licenses. I'd love a simple flag that blocked on unknown licenses. Additionally, allow-licenses and deny-licenses cannot be used together which is expected behaviour, but there is otherwise no workaround.

Recommendation: Add a new flag with default of false: fail-on-unknown-license.
Docs: When set to true, the action will fail on a pull request if 1 or more licenses have an unknown license. Use allow-dependencies-licenses to specify which packages to omit from the failure when fail-on-unknown-license is set to true.

@jonjanego
Copy link
Collaborator

Thank you @austimkelly. We've already got similar feedback that we're tracking in #672 so i'm going to close this issue as a duplicate in order to keep the issue board tidy.

@jonjanego jonjanego closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants