Include custom annotations and labels to all resources created by gha-runner-scale-set chart
#3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
nikola-jokic
added
the
gha-runner-scale-set
|
Hey @rteeling-evernorth, can you please let us know if this solution works for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we officially only support helm as the installation method, we should provide a mechanism to allow different CD tools such as ArgoCD to be used when installing scale sets.
@rteeling-evernorth did a great job creating PR #3447, eliminating deadlock when uninstalling AutoscalingRunnerSet in ArgoCD. Having that in mind, this PR intends to unblock users that not only use ArgoCD, but maybe other tools that rely on labels and annotations for resource tracking.
This PR makes it easier for those managing installations to add custom labels, allowing for easier querying later.
Fixes #3440
Fixes #3877