Merge pull request #126 from marmichalski/php84-implicit-null

fix: explicit nullable types

Author: ackintosh

src/Ganesha/GaneshaHttpClient.php

@@ -75,7 +75,7 @@ public function request(string $method, string $url, array $options = []): Respo
     /**
      * {@inheritdoc}
      */
-    public function stream($responses, float $timeout = null): ResponseStreamInterface
+    public function stream($responses, ?float $timeout = null): ResponseStreamInterface
     {
         return $this->client->stream($responses, $timeout);
     }

src/Ganesha/GuzzleMiddleware.php

@@ -43,8 +43,8 @@ class GuzzleMiddleware
 
     public function __construct(
         Ganesha $ganesha,
-        ServiceNameExtractorInterface $serviceNameExtractor = null,
-        FailureDetectorInterface $failureDetector = null
+        ?ServiceNameExtractorInterface $serviceNameExtractor = null,
+        ?FailureDetectorInterface $failureDetector = null
     ) {
         $this->ganesha = $ganesha;
         $this->serviceNameExtractor = $serviceNameExtractor ?: new ServiceNameExtractor();

src/Ganesha/Storage.php

@@ -28,7 +28,7 @@ class Storage
     public function __construct(
         AdapterInterface $adapter,
         StorageKeysInterface $storageKeys,
-        callable $serviceNameDecorator = null
+        ?callable $serviceNameDecorator = null
     ) {
         $this->adapter = $adapter;
         $this->serviceNameDecorator = $serviceNameDecorator;

src/Ganesha/Storage/Adapter/Apcu.php

@@ -19,21 +19,21 @@ class Apcu implements AdapterInterface, TumblingTimeWindowInterface
     /**
      * @param ApcuStore|null $apcuStore Backing store for testing (optional)
      */
-    public function __construct(ApcuStore $apcuStore = null)
+    public function __construct(?ApcuStore $apcuStore = null)
     {
         $this->apcuStore = $apcuStore ?? new ApcuStore();
     }
 
     /**
-     * Returns returns whether the adapter supports counting strategy
+     * Returns whether the adapter supports counting strategy
      */
     public function supportCountStrategy(): bool
     {
         return true;
     }
 
     /**
-     * Returns returns whether the adapter supports rating strategy
+     * Returns whether the adapter supports rating strategy
      */
     public function supportRateStrategy(): bool
     {

src/Ganesha/Storage/AdapterInterface.php

@@ -8,12 +8,12 @@
 interface AdapterInterface
 {
     /**
-     * Returns returns whether the adapter supports counting strategy
+     * Returns whether the adapter supports counting strategy
      */
     public function supportCountStrategy(): bool;
 
     /**
-     * Returns returns whether the adapter supports rating strategy
+     * Returns whether the adapter supports rating strategy
      */
     public function supportRateStrategy(): bool;
 

tests/Ackintosh/Ganesha/Storage/Adapter/ApcuTest.php

@@ -667,8 +667,8 @@ public function test_keyRegex(string $key, int $expectMatchResult)
     }
 
     private function getApcu(
-        ApcuStore $apcStore = null,
-        StorageKeysInterface $storageKeys = null
+        ?ApcuStore $apcStore = null,
+        ?StorageKeysInterface $storageKeys = null
     ): Apcu {
         $apc = new Apcu($apcStore);
         $context = new Ganesha\Context(
@@ -680,7 +680,7 @@ private function getApcu(
         return $apc;
     }
 
-    private function getConfiguration(StorageKeysInterface $storageKeys = null)
+    private function getConfiguration(?StorageKeysInterface $storageKeys = null)
     {
         $configuration = $this->createMock(Configuration::class);
         $configuration->method('storageKeys')