Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update User role should fail fast for unknown user IDs #2201

Open
arvindh123 opened this issue Apr 25, 2024 · 0 comments
Open

Feature: Update User role should fail fast for unknown user IDs #2201

arvindh123 opened this issue Apr 25, 2024 · 0 comments
Assignees
Milestone

Comments

@arvindh123
Copy link
Contributor

arvindh123 commented Apr 25, 2024

Is your feature request related to a problem? Please describe.

During update user role for non existence user id, doesn't fails in policy layer, Instead it fails in repo layer after adding policy in spiceDB them it rollback the policy.

Describe the feature you are requesting, as well as the possible use case(s) for it.

Instead of checking the user existence in repo layer, we should check user id is belongs to Magistrala Platform as member in policy layer( spiceDB).

Indicate the importance of this feature to you.

Should-have

Anything else?

No response

@arvindh123 arvindh123 added this to the S4 milestone May 6, 2024
@JeffMboya JeffMboya self-assigned this May 14, 2024
@dborovcanin dborovcanin changed the title Feature: In update user role , Add policy for role should fail if user id is not member of Magistrala platform Feature: Update User role should fail fast for unknown user IDs May 15, 2024
@dborovcanin dborovcanin modified the milestones: S4, S5 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧪 Review and testing in progress
Development

No branches or pull requests

3 participants