Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled from CRAN #30

Open
sneumann opened this issue Jun 10, 2023 · 5 comments
Open

Pulled from CRAN #30

sneumann opened this issue Jun 10, 2023 · 5 comments

Comments

@sneumann
Copy link
Contributor

sneumann commented Jun 10, 2023

Hi, CRAN says https://cran.r-project.org/web/packages/metabolighteR/index.html

Package ‘metabolighteR’ was removed from the CRAN repository.
Archived on 2022-11-21 for policy violation

What was the cause, and what'd be needed to get it back ?
Yours, Steffen

P.S.: I saw https://cran-archive.r-project.org/web/checks/2022/2022-11-21_check_results_metabolighteR.html
which says

get_studies()
    Error in curl::curl_fetch_memory(url, handle = handle) :
     Could not resolve host: www.ebi.ac.uk
    Execution halted 

and I am sure EBI still exists, so does not look like a road-blocker.

@wilsontom
Copy link
Member

Hi Steffan,

I think this issue was that every now and then when the daily package tests ran on the CRAN server, the mtbls server would unreachable due to maintenance. I was thinking about moving the package on to bioconductor, but for now I'll change the examples/tests to skip so it should prevent this from happening.

Will get it submitted back to CRAN this week.

Thanks

Tom

@romanzenka
Copy link

It does not seem to be on CRAN.

I am a bit nervous about testing directly against a live website. Would it be possible to scrape the responses from the website and then fake them for test purposes? That way you would have documentation of what the web used to do, way to see what it does now, CRAN would not be reaching across the world and tests would succeed reliably?

@kjemist
Copy link

kjemist commented Nov 9, 2023

Hey!

I see this is still not available on CRAN.
Are there any more future plans for this package?

@sneumann
Copy link
Contributor Author

sneumann commented Nov 9, 2023

Hi @romanzenka , that's a great idea ! Does CRAN allow tests to return a warning ?
Then the online test could be wrapped in try() and an error be downgraded to Warning,
so we still have an inkling if sth changes online. Yours, Steffen

@romanzenka
Copy link

romanzenka commented Nov 27, 2023

Does CRAN allow tests to return a warning ? Then the online test could be wrapped in try() and an error be downgraded to Warning, so we still have an inkling if sth changes online. Yours, Steffen

I am thinking that this is not something CRAN should bother with - I would want my CRAN package to test robustly, without the vagaries of the internet, otherwise you are not testing your own work, but someone else's server.

I would probably wrap that sort of test into some sort of internal function, and I'd run it on my own somewhere outside of CRAN, just to see how well is a given service performing over time. I would publish this package as: "assuming EBI works as it worked on <date>, this package will work".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants