You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is in reference to issue #33 where we may want to define a workflow to help keep this gem up to date based on new versions of heroicons being available from the official tailwindlabs/heroicons repo:
Copy all of the tailwindlabs/heroicons icons into your repo's icons folder
Is there a difference between src/ and optimized/?
Update your version based on step 2
Update your readme to reference the version from what I added in this issue's PR
Commit the changes and push the branch
Open a PR in your own repo so you can review it as a human
At this point you can merge it and cut a gem release. I don't know your workflow for updating the changelog but that step could be done manually in the PR or after you merge it but before you build a new gem.
Step 2's option 3 looks like the most appealing based on feedback from @abeidahmed.
As for testing the script:
For development I'd suggest creating it all as an offline script that you can run on the command line on your dev box without needing to push any commits. This way it can be tested in isolation with a number of different inputs. Then once it's good to go drop it into a GitHub Action.
As a first-time-end-to-end test maybe a 2nd private repo could be created just to make sure the GitHub Action portion works. I don't really know of a better way to test GitHub Actions unless you start looking into solutions like https://github.com/nektos/act (I haven't yet btw).
The text was updated successfully, but these errors were encountered:
This is in reference to issue #33 where we may want to define a workflow to help keep this gem up to date based on new versions of heroicons being available from the official tailwindlabs/heroicons repo:
A daily or weekly script could:
v2.0.16.json
instead oficons.json
, but this will make git diffing hard since the file name changed?_version
field to theicons.json
, not bad but feels like it's mixing concerns of icons and metadata?TAILWINDLABS_HEROICONS_VERSION
file somewhere within the gem, pretty good?src/
andoptimized/
?At this point you can merge it and cut a gem release. I don't know your workflow for updating the changelog but that step could be done manually in the PR or after you merge it but before you build a new gem.
Step 2's option 3 looks like the most appealing based on feedback from @abeidahmed.
As for testing the script:
For development I'd suggest creating it all as an offline script that you can run on the command line on your dev box without needing to push any commits. This way it can be tested in isolation with a number of different inputs. Then once it's good to go drop it into a GitHub Action.
As a first-time-end-to-end test maybe a 2nd private repo could be created just to make sure the GitHub Action portion works. I don't really know of a better way to test GitHub Actions unless you start looking into solutions like https://github.com/nektos/act (I haven't yet btw).
The text was updated successfully, but these errors were encountered: