-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: use zero dependencies, but use the dependencies defined in abaplint.json #183
Comments
See my comment on #181. Having a one2one relation for the dependency repository greatly improves performance. It is a one-of thing to do. As these dependencies are SAP code, it can not be public (internet wide), but will be internal repositories. Their read-access can be public to the linter. |
some kind of And also such approach needs some convenient one-click way to refresh dependedency repo |
api key: yea, probably good enough but in the general case there are multiple hosts and multiple keys/logins for each host |
multiple ... I don't think that in reality there will multiple hosts. private repos will probably be from a single corporate server. quick ideas:
|
^ I like number 3 |
see also my comments in #181. I'd also prefer envs. |
I think also @ed-holland created an issue for this somewhere
But, instead of finding and serializing dependencies in the ABAP system, have the server take the dependencies from abaplint.json.
It would have to be a setting per repository in the ABAP configuration.
Largest problem is probably handling authentication if the dependencies are not public
The text was updated successfully, but these errors were encountered: