Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our own standards -- discussions on call #6

Open
kaushalvivek opened this issue Apr 7, 2022 · 2 comments
Open

Our own standards -- discussions on call #6

kaushalvivek opened this issue Apr 7, 2022 · 2 comments

Comments

@kaushalvivek
Copy link
Collaborator

  • Verify Interface Compliance
  • argument type -- pointers, unless we're concerned that there'll be modifications downstream
  • slice as an argument (tricky, cc Anshal)
  • channel size non-unit buffer
  • error : document our own structure
  • lifecycle management before container based deployment
  • line-length: we need a cap on line size, check if this can be done through a linter
  • plural package name -- do it when it makes sense, at max two words concatenated
  • file-size: capped at 500/1000 lines
  • separating services at proto level -- cc Anshal
@kaushalvivek
Copy link
Collaborator Author

  • enum -- add context
  • go enum -- prefix with type

@kaushalvivek
Copy link
Collaborator Author

We are okay with goDoc errors -- anything else should be resolved before merging with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant