Mapped new nodes to Images #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge updates from original
evalmay15
approved these changes
Jan 23, 2018
There was a problem hiding this comment.
Nodes mapped: Conjuration, Destruction, Alteration, Alchemy, Block, Archery. 👍
We will need to reorder some nodes for dependencies, however they are all correctly mapped. 😄 And they look so pretty when testing! ❤️
We still need to map Illusion, Restoration, Enchanting, Smithing, Heavy Armor, One-Handed, Light Armor, Lockpicking and Pickpocket. All of these have all nodes created so it should be easy. 🤔
|
Great job! That's a hefty amount you did there! @evalmay15 please copy your Approval message to the issue tracker, and update the Progress Table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Which issue does this PR fix?: fixes #19
Brief description of what this PR does.
Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber"
Alchemy, Alteration, Archery, Block, Conjuration, Destruction Nodes are added.
Why do we need this PR?:
If relevant, please include a screenshot.
Demo (optional):
Some tips for you to write the instructions:
Testing instructions:
If there is any work still left to do, please add it here.
TODOs (if any):
Enchanting, Heavy Armor, Illusion, Light Armor, Lockpicking, One-Handed, Pickpocket, Restoration, Smithing still need to be mapped.