Skip to content

Commit 5d5ccfb

Browse files
flyingsilverfinjmsfltchr
authored andcommitted
Move non-Grakn Dependency (typedb#81)
## What is the goal of this PR? The current structure of `dependencies/graknlabs/dependencies.bzl` was breaking graql and `sync-dependencies` because it contained a non-graknlabs dependency. ## What are the changes implemented in this PR? * Create a new package `dependencies/python` * move relevant rule from `graknlabs/dependencies.bzl` to `python/dependencies.bzl` * Update WORKSPACE correspondingly
1 parent 90fb2ae commit 5d5ccfb

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
1212
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_file")
1313

1414
# We require loading bazel_rules from the graknlabs fork, not from bazel, since we've patched the python rules to work with TensorFlow
15-
load("//dependencies/graknlabs:dependencies.bzl", "io_bazel_rules_python")
15+
load("//dependencies/python:dependencies.bzl", "io_bazel_rules_python")
1616
io_bazel_rules_python()
1717

1818
## Only needed for PIP support:

dependencies/graknlabs/dependencies.bzl

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
22

3-
4-
def io_bazel_rules_python():
5-
git_repository(
6-
name = "io_bazel_rules_python",
7-
# Grakn python rules
8-
remote = "https://github.com/graknlabs/rules_python.git",
9-
commit = "4443fa25feac79b0e4c7c63ca84f87a1d6032f49" # sync-marker: do not remove this comment, this is used for sync-dependencies by @io_bazel_rules_python
10-
)
11-
123
def graknlabs_build_tools():
134
git_repository(
145
name = "graknlabs_build_tools",
@@ -29,4 +20,4 @@ def graknlabs_client_python():
2920
name = "graknlabs_client_python",
3021
remote = "https://github.com/graknlabs/client-python",
3122
commit = "957ec0d41d59ea24d349a76bf50199b742cb0756" # sync-marker: do not remove this comment, this is used for sync-dependencies by @graknlabs_client_python
32-
)
23+
)

dependencies/python/BUILD

Whitespace-only changes.

dependencies/python/dependencies.bzl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
2+
3+
4+
def io_bazel_rules_python():
5+
git_repository(
6+
name = "io_bazel_rules_python",
7+
# Grakn python rules
8+
remote = "https://github.com/graknlabs/rules_python.git",
9+
commit = "4443fa25feac79b0e4c7c63ca84f87a1d6032f49"
10+
)

0 commit comments

Comments
 (0)