Docstrings, minor #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the end the PR does introduce minor changes in functionality (fixes), pls have a look at the commit message in 87d12e7 |
opcode81
reviewed
Feb 26, 2024
opcode81
reviewed
Feb 26, 2024
opcode81
reviewed
Feb 26, 2024
opcode81
reviewed
Feb 26, 2024
opcode81
reviewed
Feb 26, 2024
opcode81
reviewed
Feb 26, 2024
MischaPanch
force-pushed
the
infinimol
branch
from
bf44fa5
to
afe6e18
Compare
|
@MischaPanch I rebased and force-pushed the branch to clean up the history. If you approve, feel free to merge this any time. |
* Improve docstrings/comments * Improve type hints * Add parameters 'array_valued' and 'fit' to RuleTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I slightly rephrased some normalisation-rule related things, maybe the only part that needs looking at