Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not use anymore in blender3.1 #43

Open
BUGProtectionAssociation opened this issue Nov 3, 2021 · 6 comments
Open

can not use anymore in blender3.1 #43

BUGProtectionAssociation opened this issue Nov 3, 2021 · 6 comments

Comments

@BUGProtectionAssociation
Copy link

BUGProtectionAssociation commented Nov 3, 2021

Have trouble?

@BUGProtectionAssociation BUGProtectionAssociation changed the title can not can not use anymore in blender3.1 Nov 3, 2021
@ldo
Copy link

ldo commented Nov 3, 2021

What exactly is the problem?

@doulos0
Copy link

doulos0 commented Nov 25, 2021

Error for Blender 3.0

Python: Traceback (most recent call last):
File "/home/doulos/.config/blender/3.0/scripts/addons/SpaceshipGenerator-master/init.py", line 43, in execute
spaceship_generator.generate_spaceship(
File "/home/doulos/.config/blender/3.0/scripts/addons/SpaceshipGenerator-master/spaceship_generator.py", line 669, in generate_spaceship
add_surface_antenna_to_face(bm, face)
File "/home/doulos/.config/blender/3.0/scripts/addons/SpaceshipGenerator-master/spaceship_generator.py", line 341, in add_surface_antenna_to_face
result = bmesh.ops.create_cone(bm,
TypeError: create_cone: keyword "diameter1" is invalid for this operator

location: :-1

@ldo
Copy link

ldo commented Nov 25, 2021

Seems that what was called the “diameter” argument in these BMesh operators was in fact being interpreted as the radius all along, according to this commit. Which is why it has been renamed as of 3.0.

@sbarre
Copy link

sbarre commented Dec 1, 2021

I've got a fork of the addon where I've patched the script to work in Blender 3+

You can find it here: https://github.com/sbarre/SpaceshipGenerator/tree/blender-3

It was a very simple fix, just a search/replace operation in one file, so you can also just patch your locally installed version of the addon instead.

I've opened a PR on here to discuss it, although I don't think it should be merged into master yet because it might(?) break in 2.9 or lower.

@ldo
Copy link

ldo commented Dec 4, 2021

Oddly, this particular item missed being mentioned in the breaking changes to the Python API ...

@Agroithien
Copy link

I've got a fork of the addon where I've patched the script to work in Blender 3+

You can find it here: https://github.com/sbarre/SpaceshipGenerator/tree/blender-3

It was a very simple fix, just a search/replace operation in one file, so you can also just patch your locally installed version of the addon instead.

I've opened a PR on here to discuss it, although I don't think it should be merged into master yet because it might(?) break in 2.9 or lower.

Initially, This is not working for me in blender 3.1.2 but I changed
num_segments = uniform(3, 6) to num_segments = randint(3, 6)
on line number 340 inside spaceship_generator.py It was a long shot tho. but it worked like a charm...
thanks me later lol...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants