Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review deduplication doesn't work in some cases when combining Windows and Linux #129

Closed
bwrsandman opened this issue May 24, 2024 · 0 comments · Fixed by #130
Closed

Review deduplication doesn't work in some cases when combining Windows and Linux #129

bwrsandman opened this issue May 24, 2024 · 0 comments · Fixed by #130

Comments

@bwrsandman
Copy link
Contributor

bwrsandman commented May 24, 2024

Some messages ask to change variable names and will have different positions where these changes must happen
e.g.

src/main.cpp:42

-foo = 0;
+bar=0;

The issue is that if the review step was run on windows runner, the message will use forward slashes

src\main.cpp:42

-foo = 0;
+bar=0;

This results in an inability to de-duplicate the message since src/main.cpp:42 is different from src\main.cpp:42

I think a solution would be to convert all \\ characters to / for the comparison tests and make sure that works also for already posted messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant