We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some messages ask to change variable names and will have different positions where these changes must happen e.g.
src/main.cpp:42 -foo = 0; +bar=0;
src/main.cpp:42
-foo = 0; +bar=0;
The issue is that if the review step was run on windows runner, the message will use forward slashes
src\main.cpp:42 -foo = 0; +bar=0;
src\main.cpp:42
This results in an inability to de-duplicate the message since src/main.cpp:42 is different from src\main.cpp:42
I think a solution would be to convert all \\ characters to / for the comparison tests and make sure that works also for already posted messages.
\\
/
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Some messages ask to change variable names and will have different positions where these changes must happen
e.g.
The issue is that if the review step was run on windows runner, the message will use forward slashes
This results in an inability to de-duplicate the message since
src/main.cpp:42
is different fromsrc\main.cpp:42
I think a solution would be to convert all
\\
characters to/
for the comparison tests and make sure that works also for already posted messages.The text was updated successfully, but these errors were encountered: