Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature request) withBinarySerialization for the request? #297

Open
AkosLukacs opened this issue Apr 28, 2022 · 1 comment
Open

(feature request) withBinarySerialization for the request? #297

AkosLukacs opened this issue Apr 28, 2022 · 1 comment

Comments

@AkosLukacs
Copy link

Hi,

Currently withBinarySerialization sets the server's response serialization to MsgPack, but the request from the client is still in JSON.
Would it possible to switch the client -> server request to messagepack as well? Or is anything blocking this?

@kerams
Copy link
Collaborator

kerams commented Apr 28, 2022

This is something I was looking into in the past. I don't recall there being any blockers, but JSON serialization is baked in the request side of things a little deeper and I just didn't feel like putting in the effort into it, since the benefits would be much smaller than for binary response serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants