feat: improve performance of tests and cleanup code

Author: Zac-Zajdel

package.json

@@ -8,7 +8,8 @@
     "start": "next start",
     "lint": "next lint",
     "test": "vitest run",
-    "format": "prettier --write \"**/*.{css,js,json,jsx,ts,tsx}\""
+    "format": "prettier --write \"**/*.{css,js,json,jsx,ts,tsx}\"",
+    "reset": "prisma migrate reset"
   },
   "dependencies": {
     "@auth/prisma-adapter": "^2.4.1",

tests/auth/external-api-auth-error.test.ts

@@ -1,7 +1,6 @@
-import { prisma } from '@/lib/db';
 import { IntegrationHarness } from '@/tests/utils/integration';
 import { OasisTestContext } from '@/tests/utils/setup';
-import { afterAll, expect, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 test('EXTERNAL API AUTH ERROR', async (ctx: OasisTestContext) => {
   ctx.apiToken = 'INVALID API TOKEN';
@@ -23,7 +22,3 @@ test('EXTERNAL API AUTH ERROR', async (ctx: OasisTestContext) => {
   expect(success).toBe(false);
   expect(error).toBe('Unauthorized: Invalid API Token');
 });
-
-afterAll(async () => {
-  await prisma.apiToken.deleteMany({});
-});

tests/auth/internal-api-auth-error.test.tsx

@@ -1,7 +1,6 @@
-import { prisma } from '@/lib/db';
 import { IntegrationHarness } from '@/tests/utils/integration';
 import { OasisTestContext } from '@/tests/utils/setup';
-import { afterAll, expect, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 test('INTERNAL API AUTH ERROR', async (ctx: OasisTestContext) => {
   const h = new IntegrationHarness(ctx);
@@ -21,7 +20,3 @@ test('INTERNAL API AUTH ERROR', async (ctx: OasisTestContext) => {
   expect(success).toBe(false);
   expect(error).toBe('Unauthorized');
 });
-
-afterAll(async () => {
-  await prisma.apiToken.deleteMany({});
-});

tests/bookmarks/create-bookmark.test.ts

@@ -39,5 +39,4 @@ test('POST /bookmarks', async (ctx: OasisTestContext) => {
 
 afterAll(async () => {
   await prisma.bookmark.deleteMany({});
-  await prisma.apiToken.deleteMany({});
 });

tests/bookmarks/get-bookmarks.test.ts

@@ -47,5 +47,4 @@ test('GET /bookmarks', async (ctx: OasisTestContext) => {
 
 afterAll(async () => {
   await prisma.bookmark.deleteMany({});
-  await prisma.apiToken.deleteMany({});
 });

tests/tokens/create-token.test.ts

@@ -2,7 +2,7 @@ import { hashApiToken } from '@/lib/api/apiTokens/utils';
 import { prisma } from '@/lib/db';
 import { IntegrationHarness } from '@/tests/utils/integration';
 import { OasisTestContext, getSetupData } from '@/tests/utils/setup';
-import { afterAll, expect, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 test('POST /tokens', async (ctx: OasisTestContext) => {
   const setup = await getSetupData();
@@ -43,7 +43,3 @@ test('POST /tokens', async (ctx: OasisTestContext) => {
     }),
   );
 });
-
-afterAll(async () => {
-  await prisma.apiToken.deleteMany({});
-});

tests/utils/setup.ts

@@ -9,10 +9,14 @@ export interface OasisTestContext extends TestContext {
   apiToken: string;
 }
 
-let apiToken: string;
-let user: User;
+declare global {
+  var user: User;
+  var apiToken: string;
+}
 
 beforeAll(async () => {
+  if (global.user && global.apiToken) return;
+
   const apiUser = await prisma.user.upsert({
     where: {
       email: '[email protected]',
@@ -23,23 +27,24 @@ beforeAll(async () => {
       email: '[email protected]',
     },
   });
-  user = apiUser;
+
+  global.user = apiUser;
 
   const token = randomBytes(32).toString('hex');
   await prisma.apiToken.create({
     data: {
-      userId: user.id,
+      userId: apiUser.id,
       name: faker.lorem.word(),
       token: await hashApiToken(token),
     },
   });
 
-  apiToken = token;
+  global.apiToken = token;
 });
 
 export function getSetupData() {
   return {
-    apiToken,
-    user,
+    apiToken: global.apiToken,
+    user: global.user,
   };
 }

vitest.config.ts

@@ -9,5 +9,6 @@ export default defineConfig({
     testTimeout: 50000,
     setupFiles: './tests/utils/setup.ts',
     fileParallelism: false,
+    isolate: false,
   },
 });