Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parserのリファクタ #385

Open
YuukiToriyama opened this issue Aug 24, 2024 · 2 comments
Open

parserのリファクタ #385

YuukiToriyama opened this issue Aug 24, 2024 · 2 comments
Assignees
@YuukiToriyama
Labels
Core コアモジュール関連の修正 enhancement New feature or request

Comments

@YuukiToriyama
Copy link
Owner

概要

  • Typestateパターンで書いている箇所をループを使ってもう少しスマートな形に書き換える
  • PhantomTypeとしてstructを使用しているため、match式が使えないが、enumを使用するようにしたらmatch式&loopで上手く書けないか

その他
@YuukiToriyama YuukiToriyama self-assigned this Aug 24, 2024
@YuukiToriyama YuukiToriyama added enhancement New feature or request Core コアモジュール関連の修正 labels Aug 24, 2024
@YuukiToriyama
Copy link
Owner Author

PhantomDataを用いる場合、実行時には型情報が消えてしまっているため、match式でパターンマッチングができない

@YuukiToriyama
Copy link
Owner Author

PhantomDataを使わないでもTypeStateパターンは実現できるが、match式で動的に処理を切り替えるのは難しい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuukiToriyama YuukiToriyama

Labels
Core コアモジュール関連の修正 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YuukiToriyama