Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

マルチモジュール化 #178

Closed
YuukiToriyama opened this issue Feb 25, 2024 · 2 comments · Fixed by #197
Closed

マルチモジュール化 #178

YuukiToriyama opened this issue Feb 25, 2024 · 2 comments · Fixed by #197
Assignees
@YuukiToriyama
Labels
enhancement New feature or request
Milestone
マルチモジュール化

Comments

@YuukiToriyama
Copy link
Owner

マルチモジュール化というかcargo workspaceを導入し、クレートを分割する
@YuukiToriyama YuukiToriyama self-assigned this Feb 25, 2024
@YuukiToriyama YuukiToriyama added the enhancement New feature or request label Feb 25, 2024
@YuukiToriyama YuukiToriyama mentioned this issue Feb 25, 2024
Merged
@YuukiToriyama
Copy link
Owner Author

YuukiToriyama commented Feb 26, 2024 •
edited
Loading

  • coreモジュールを作成し、既存のsrc以下を移動させる
  • JavaScript向けのコードをwasmモジュールとして切り出す
  • 同時にGitHubのワークフローも整理する
  • docsもモジュールとして切り出す？

This was referenced Feb 28, 2024
Merged
Closed
@YuukiToriyama
Copy link
Owner Author

  • coreモジュールのlib.crate-typeの指定は除却してしまっても構わないか
  • ParseResultをJsValueに変換する処理がcoreモジュールに残っているが、除却できないか

@YuukiToriyama YuukiToriyama mentioned this issue Mar 6, 2024
Merged
This was referenced Mar 22, 2024
Merged
Merged
@YuukiToriyama YuukiToriyama linked a pull request Mar 22, 2024 that will close this issue
release/v0.1.0-beta.10をmainブランチにマージ #197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuukiToriyama YuukiToriyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
マルチモジュール化
Development

Successfully merging a pull request may close this issue.

release/v0.1.0-beta.10をmainブランチにマージ YuukiToriyama/japanese-address-parser
1 participant
@YuukiToriyama