Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longestCommonSubsequence return wrong result #196

Open
JauSingSing opened this issue Sep 24, 2022 · 1 comment
Open

longestCommonSubsequence return wrong result #196

JauSingSing opened this issue Sep 24, 2022 · 1 comment

Comments

@JauSingSing
Copy link

var suffixArray = new GeneralizedSuffixArray([
  [1,2,3,4],
  [2,3,4],
  [1,2,3,4]
])
suffixArray.longestCommonSubsequence()
>>> [1,2,3,4]

expect [2, 3, 4]

Yomguithereal added a commit that referenced this issue Oct 4, 2022
@Yomguithereal
Copy link
Owner

Hello @JauSingSing, you are right there is something fishy there. I think I need to rewrite this code to fix those kind of cases and optimize it altogether, I wrote this quite a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants