-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Pydantic 2 or make Pydantic support optional? #23
Comments
@Yiling-J you have done a good job, nice lib, but sincerely we need to update it to pydantic v2 |
@eykd @aspatari Sorry for no replying because I miss the notification when this issue was opened (seems I didn't even receive it). I'm not very familiar with Pydantic and haven't been using Python recently. It would be greatly appreciated if you could help @aspatari. but if you're busy I can certainly take a look into it myself. |
@eykd @aspatari After reading the Pydantic documentation a bit, I think it might be better to remove the serializer concept altogether and instead adding
Considering that cacheme isn't widely adopted (13 downloads last week), I think removing the serializer won't introduce any significant issues. |
I'm working a Starlette project that uses Pydantic v2. I'd be interested in trying out cacheme, but the conflicting Pydantic version requirements make it impossible. Two obvious options present themselves:
object_encoder
/object_decoder
on the Serialization classes, with the default being an identity function for accepting/returning primitive types.Thank you for considering this.
The text was updated successfully, but these errors were encountered: