Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend shape features #168

Open
4 tasks
ckmah opened this issue Nov 23, 2024 · 0 comments
Open
4 tasks

Extend shape features #168

ckmah opened this issue Nov 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ckmah
Copy link
Collaborator

ckmah commented Nov 23, 2024

To properly handle more complex feature calculations for Shapes, shape features need to accommodate:

  • features per cell
  • features for subcellular shapes
    • 1 to 1 mapped shapes e.g. single nuclei
    • many to 1 mapped shapes e.g. multiple nuclei, organelles
  • keep in mind: output should be easy to interface (store in joined tables) with point features (also store in tables? aligned to instance_key)

Potential designs:

  • keep current functional wrappers for cell features
    • pros: least code change
    • cons: may become harder to track/enforce how output is stored spatialdata object
  • use OOP design similar to PointFeatures implementation
    • pros: PointFeatures can more easily infer attribute names for shape features they depend on
    • cons: significantly more code
@ckmah ckmah added the enhancement New feature or request label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant