tests in phpspec

Author: Yavin

.gitignore

@@ -1,2 +1,3 @@
 /vendor
-.composer.lock
+/composer.lock
+/bin

.travis.yml

@@ -0,0 +1,11 @@
+language: php
+
+php:
+  - 5.4
+  - 5.5
+
+install:
+  - composer install
+
+script:
+  - bin/phpspec run -f dot

composer.json

@@ -1,21 +1,24 @@
 {
     "name": "yavin/symfony-init-controller",
     "description": "Runs init controller method before every action",
+    "license": "mit",
+    "authors": [
+        {"name": "Yavin", "email": "[email protected]"}
+    ],
     "require": {
         "symfony/http-kernel": "~2.0",
         "symfony/event-dispatcher": "~2.0"
     },
-    "license": "mit",
-    "authors": [
-        {
-            "name": "Yavin",
-            "email": "[email protected]"
-        }
-    ],
+    "require-dev": {
+        "phpspec/phpspec": "~2.0"
+    },
     "minimum-stability": "stable",
     "autoload": {
         "psr-0":{
-            "Yavin":"src/"
+            "Yavin": "src/"
         }
+    },
+    "config": {
+        "bin-dir": "bin"
     }
 }

spec/Yavin/Symfony/Controller/InitControllerSubscriberSpec.php

@@ -0,0 +1,59 @@
+<?php
+
+namespace spec\Yavin\Symfony\Controller;
+
+require_once __DIR__ . '/NormalController.php';
+require_once __DIR__ . '/SampleInitController.php';
+
+use PhpSpec\ObjectBehavior;
+use Prophecy\Argument;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
+
+class InitControllerSubscriberSpec extends ObjectBehavior
+{
+    public function it_should_be_event_subscriber()
+    {
+        $this->shouldHaveType('Symfony\Component\EventDispatcher\EventSubscriberInterface');
+    }
+
+    public function it_should_listen_to_kernel_controller_event()
+    {
+        $this::getSubscribedEvents()->shouldReturn(array(
+            'kernel.controller' => 'onKernelController',
+        ));
+    }
+
+    public function it_should_run_init_method(
+        FilterControllerEvent $event,
+        Request $request,
+        SampleInitController $controller
+    ) {
+        $event->getRequest()->willReturn($request);
+        $event->getController()->willReturn(array($controller));
+        $controller->init($request)->shouldBeCalled();
+
+        $this->onKernelController($event);
+    }
+
+    public function it_should_not_call_init_when_not_implementing_interface(
+        FilterControllerEvent $event,
+        Request $request,
+        NormalController $controller
+    ) {
+        $event->getRequest()->willReturn($request);
+        $event->getController()->willReturn(array($controller));
+
+        $this->onKernelController($event);
+    }
+
+    public function it_should_do_nothing_when_controller_is_some_other_callable(
+        FilterControllerEvent $event,
+        Request $request
+    ) {
+        $event->getRequest()->willReturn($request);
+        $event->getController()->willReturn(array(function() {}));
+
+        $this->onKernelController($event);
+    }
+}

spec/Yavin/Symfony/Controller/NormalController.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace spec\Yavin\Symfony\Controller;
+
+use Symfony\Component\HttpFoundation\Request;
+use Yavin\Symfony\Controller\InitControllerInterface;
+
+class NormalController implements InitControllerInterface
+{
+    public function init(Request $request)
+    {
+
+    }
+}

spec/Yavin/Symfony/Controller/SampleInitController.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace spec\Yavin\Symfony\Controller;
+
+use Symfony\Component\HttpFoundation\Request;
+use Yavin\Symfony\Controller\InitControllerInterface;
+
+class SampleInitController implements InitControllerInterface
+{
+    public function init(Request $request)
+    {
+
+    }
+}

src/Yavin/Symfony/Controller/InitControllerSubscriber.php

@@ -26,7 +26,7 @@ public function onKernelController(FilterControllerEvent $event)
     {
         $controller = $event->getController();
 
-        if (!is_array($controller)) {
+        if (empty($controller) || !is_array($controller)) {
             // not a object but a different kind of callable. Do nothing
             return;
         }