Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated usage of spawn in VT lookup commands #81

Open
YamatoSecurity opened this issue Dec 23, 2023 · 2 comments · May be fixed by #88
Open

Deprecated usage of spawn in VT lookup commands #81

YamatoSecurity opened this issue Dec 23, 2023 · 2 comments · May be fixed by #88
Assignees
@fukusuket
Labels
invalid This doesn't seem right pending

Comments

@YamatoSecurity
Copy link
Collaborator

After updating nim to 2.0.2 with choosenim update stable I am getting the following error:

takajo-main/src/takajo.nim(15, 8) Warning: use the nimble packages `malebolgia`, `taskpools` or `weave` instead; threadpool is deprecated [Deprecated]
@YamatoSecurity YamatoSecurity changed the title Deprecated error Deprecated usage of spawn in VT lookup commands Jan 27, 2024
@YamatoSecurity YamatoSecurity added the invalid This doesn't seem right label Jan 27, 2024
@YamatoSecurity
Copy link
Collaborator Author

@fukusuket I found the cause of this. In the three vt commands, it is causing the deprecated error due to the use of spawn from the threadpool library. Could you rewrite the parallel processing to use malebolgia instead?
https://github.com/Araq/malebolgia
malebolgia is written by the author of Nim so will probably be maintained in the future and seems to be suitable for our purpose.

@fukusuket
Copy link
Collaborator

@YamatoSecurity
Thank you for the information! Yes, I'll try it💪

@fukusuket fukusuket self-assigned this Jan 27, 2024
@YamatoSecurity YamatoSecurity added this to the v2.3.1 milestone Jan 27, 2024
@fukusuket fukusuket linked a pull request Jan 27, 2024 that will close this issue
Draft
@YamatoSecurity YamatoSecurity modified the milestones: v2.3.1, v2.4.0 Feb 9, 2024
@YamatoSecurity YamatoSecurity removed this from the v2.4.0 milestone Feb 26, 2024
@hitenkoku hitenkoku mentioned this issue Mar 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fukusuket fukusuket

Labels
invalid This doesn't seem right pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changed threadpool -> malebolgia Yamato-Security/takajo
2 participants
@fukusuket @YamatoSecurity