Custom explainxkcd rendering

[aaronliu0130]

I love this app, but the explainxkcd rendering is quite inconvenient, especially on iPhone. I was wondering if you could get their Wikitext (through their API), render the headings and links, and just slap them into the app?

[codetheweb]

I have no plans to do this myself but happy to accept a PR implementing this. :)

[aaronliu0130]

For anyone looking to implement, https://www.explainxkcd.com/wiki/index.php/418:_Stove_Ownership?action=render would be a nice starting point and https://www.mediawiki.org/wiki/API:Main_page has docs for an API that can return in JSON, XML or PHP.

[aaronliu0130]

Actually, while the rest isn't done, I'll PR the starting point.

Edit: Nevermind I can't navigate swift lol

[aaronliu0130]

I have tracked the code down to https://github.com/XKCDY/app/blob/master/XKCDY/Support/XKCDYClient.swift#L42 . @codetheweb Is there a way to automatically append ?action=render to the explainURL property of whatever the returned thing is? I have no idea what this entire result thing is 😅
Also, // TODO: remove this hack for iOS 14 once it's out of beta

[codetheweb]

I would probably add it within https://github.com/XKCDY/app/blob/master/XKCDY/Views/ComicDetailsSheet.swift rather than at time of API response. Might be easier to toggle between this and the old rendering method as well with a user setting.

[aaronliu0130]

So you're saying (without the setting) it would be self.webViewUrl = explainURL + "?action=render"? Should I go ahead and PR this?

[codetheweb]

Should I go ahead and PR this?

Go for it 👍