fix: missing allowed_uuids or <server>.<state> section threw an error. add loggers on proxy connection events for better debuggability

Author: oddlama

vane-proxy-core/src/main/java/org/oddlama/vane/proxycore/VaneProxyPlugin.java

@@ -103,6 +103,8 @@ public ProxyServer get_proxy() {
 	}
 
 	public void try_start_server(ManagedServer server) {
+		// FIXME: this is not async-safe and there might be conditions where two start commands can be executed 
+		// simultaneously. Don't rely on this as a user - instead use a start command that is atomic.
 		if (server_starting) return;
 
 		this.server.get_scheduler()
@@ -111,6 +113,8 @@ public void try_start_server(ManagedServer server) {
 						() -> {
 							try {
 								server_starting = true;
+								get_logger().log(Level.INFO, "Running start command for server " + server.id());
+								System.out.println("run start cmd for " + server.id()  + ": " + server.start_cmd());
 								final var timeout = server.command_timeout();
 								final var process = Runtime.getRuntime().exec(server.start_cmd());
 

vane-proxy-core/src/main/java/org/oddlama/vane/proxycore/config/AuthMultiplex.java

@@ -11,7 +11,7 @@ public class AuthMultiplex {
 	public AuthMultiplex(Integer port, List<String> allowed_uuids) {
 		this.port = port;
 
-		if (allowed_uuids.isEmpty()) {
+		if (allowed_uuids == null || allowed_uuids.isEmpty()) {
 			this.allowed_uuids = List.of();
 		} else {
 			this.allowed_uuids = allowed_uuids.stream().filter(s -> !s.isEmpty()).map(UUID::fromString).collect(Collectors.toList());

vane-proxy-core/src/main/java/org/oddlama/vane/proxycore/config/ManagedServer.java

@@ -117,6 +117,10 @@ private static class StatefulConfiguration {
 
 		public StatefulConfiguration(String id, String display_name, CommentedConfig config) throws IOException {
 			// [managed_servers.my_server.state]
+			if (config == null) {
+				// The whole section is missing
+				return;
+			}
 
 			// quotes = ["", ...]
 			List<String> quotes = config.get("quotes");

vane-proxy-core/src/main/java/org/oddlama/vane/proxycore/listeners/LoginEvent.java

@@ -32,12 +32,15 @@ public final void fire() {
 			return;
 		}
 
+		plugin.get_logger().log(Level.INFO, "Connection '" + connection.get_name() + "' is connecting to '" + server_info.getName() + "'");
+
 		// Start server if necessary
 		if (!plugin.is_online(server_info)) {
 			// For use inside callback
 			final var cms = plugin.get_config().managed_servers.get(server_info.getName());
 
 			if (!connection.can_start_server(plugin.get_proxy(), server_info.getName())) {
+				plugin.get_logger().log(Level.INFO, "Disconnecting '" + connection.get_name() + "' because they don't have the permission to start server '" + server_info.getName() + "'");
 				// TODO: This could probably use a configurable message?
 				this.cancel("Server is offline");
 				return;