-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Published package still require @octokit/core@5, which breaks peer dependency #622
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Please don't use 11.3.1 It's a special back port release for CJS users, which is not published to the main npm tag The proper release to use is 11.3.0 |
@wolfy1339 that didn't solve anything. the package managers will resolve it to version v11.3.1 (at least pnpm) |
There are no changes in this release Fixes #622
You can force your package manager to use whichever version you want. In the end you can manually edit your lockfile and I triggered a new release that should fix the issue |
🎉 This issue has been resolved in version 11.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for quick response and the new release! Writing overrides in package.json resolved the problem for now: {
"pnpm": {
"overrides": {
"@octokit/plugin-paginate-rest": "11.3.0",
"@octokit/plugin-rest-endpoint-methods": "13.2.1"
}
}
} The new release also works. |
fyi, @viceice it's probable best not to have It avoids all issues like this and any compability issues that arise when you use different Octokit versions that what |
That would make things more complicated, because we need a lot plugins, which are not installed by default. |
We install plugins as |
I install plugins as needed as part of the release workflow. I wish there was something like |
What happened?
Though
plugin-paginate-rest.js/package.json
Line 33 in 631e726
@octokit/core@>=6
as peer dependency, the published package still require@octokit/core@5
. This breaks peer dependency on our environment.Versions
Node.js v20.15.0
pnpm v9.4.0
@octokit/core 6.1.2
@octokit/rest 21.0.0
@octokit/plugin-paginate-rest 11.3.1
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: