Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve sitemap pages over https #121

Open
AndrewHaine opened this issue Mar 22, 2022 · 4 comments
Open

Serve sitemap pages over https #121

AndrewHaine opened this issue Mar 22, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@AndrewHaine
Copy link
Contributor

AndrewHaine commented Mar 22, 2022

this may be a separate issue but we're also having problems with sitemap erroring in production due to it being rendered in http rather than https. Setting the APP_URL to https does not help, nor does enforcing https in the AppServiceProvider.

Looking into this further, I've found that the addon serves via http on servers behind load balancers. Are you able to add some configuration that forces sitemap.xml to serve https? At the moment it is only the aardvark seo tools which are being served in http

Originally posted by @AdD959 in #113 (comment)

@joshuanoyes joshuanoyes added the enhancement New feature or request label Jun 1, 2023
@joshuanoyes joshuanoyes added this to the 3.1 milestone Jun 1, 2023
@joshuanoyes joshuanoyes removed this from the 3.1 milestone Jun 27, 2023
@krsilas
Copy link

krsilas commented Jan 14, 2024

I'm currently struggling with this as well. Is there any way to fix it?

@AdD959
Copy link

AdD959 commented May 9, 2024

I ran into this issue again 2 years later with another site. Any chance of this being addressed?

@krsilas
Copy link

krsilas commented May 9, 2024

@AdD959 For me the issue was actually not really related to aardvark-seo. I'm running the laravel app behind a proxy and I had to configure a trusted proxy (https://laravel.com/docs/10.x/requests#configuring-trusted-proxies)

@AdD959
Copy link

AdD959 commented May 9, 2024

@krsilas you're right and I believe this was the solution I also found at the time, thanks for that! Good to have a reference here if anyone else stumbles upon the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants