Skip to content

Commit c95a615

Browse files
jcpetruzzafacebook-github-bot
authored andcommitted
Fix pid formatting in thread name
Summary: # Context In D72163055 we changed the formatting of the process "thread name", so that we rely on a string representation that comes as process info, instead of round-tripping again to the debuggee node for each process, to format it properly. # Problem Because we now get a "binary" representing the pid, we need to make sure to use `~s` instead of `~p` when further formatting. Because we failed to do it, we were showing the pid as a binary for processes with a registered name # This diff Fix the formatting Reviewed By: robertoaloi Differential Revision: D72305729 fbshipit-source-id: 926d8a4f263672618ae30bcf5276e6b3566ff8aa
1 parent 16f05c5 commit c95a615

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

edb/src/edb_dap_request_threads.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ process_name_label(Info = #{pid_string := PidString}) ->
8585
undefined ->
8686
PidString;
8787
RegisteredName ->
88-
io_lib:format(~"~p (~p)", [PidString, RegisteredName])
88+
io_lib:format(~"~s (~p)", [PidString, RegisteredName])
8989
end.
9090

9191
-spec message_queue_len_label(edb:process_info()) -> iodata().

0 commit comments

Comments
 (0)