Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod installation order should be preserved when uninstalling mod components #232

Open
Argent77 opened this issue Nov 27, 2023 · 1 comment

Comments

@Argent77
Copy link
Contributor

How to reproduce

1. Create first mod script in game folder: mod1.tp2

BACKUP ~weidu_external/backup/mod1~
AUTHOR ~Argent77~

BEGIN ~Component A~ DESIGNATED 1
BEGIN ~Component B~ DESIGNATED 2

2. Create a second mod script in game folder: mod2.tp2

BACKUP ~weidu_external/backup/mod2~
AUTHOR ~Argent77~

BEGIN ~Component 1~ DESIGNATED 1

3. Install mod components:

weidu mod1.tp2 --force-install 1
weidu mod2.tp2 --force-install 1
weidu mod1.tp2 --force-install 2

Resulting WeiDU.log content:

~MOD1.TP2~ #0 #1 // Component A
~MOD2.TP2~ #0 #1 // Component 1
~MOD1.TP2~ #0 #2 // Component B

4. Uninstall the first mod component of "mod1" (Component A):

weidu mod1.tp2 --force-uninstall 1

Resulting WeiDU.log content:

~MOD1.TP2~ #0 #2 // Component B
~MOD2.TP2~ #0 #1 // Component 1

Expected WeiDU.log content:

~MOD2.TP2~ #0 #1 // Component 1
~MOD1.TP2~ #0 #2 // Component B
@FredrikLindgren
Copy link
Member

FredrikLindgren commented Nov 28, 2023

Yeah, the fix for this is superficially easy, but it's one of those things I worry could have unintended consequences. I guess I'll think about it. For future me or other interested parties, this is caused by this conditional. Knock it out and everything should be handled by this and beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants