Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notification when source strings are added or updated #10651

Closed
2 tasks done
laoneo opened this issue Dec 18, 2023 · 20 comments · Fixed by #11640
Closed
2 tasks done

No notification when source strings are added or updated #10651

laoneo opened this issue Dec 18, 2023 · 20 comments · Fixed by #11640
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
5.6

Comments

@laoneo
Copy link

laoneo commented Dec 18, 2023 •
edited

Describe the issue

When a source strings get's updated or added in a component through a git commit in the en-GB "Monolingual base language file", then no notification mail goes out. In the notification settings I'v set "New string is available for translation" and "String was changed" to instant notification. Do I miss here something or is this a bug?

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Choose a translated language in the user settings
  2. Watch a project in the user settings
  3. Set all notifications to Instant in the user settings
  4. Commit a new string and an update string in a base monolingual file

Expected behavior

A notification mail goes out to the user.

Screenshots

image

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

5.3

Weblate deploy checks

No response

Additional context

No response
@nijel
Copy link
Member

nijel commented Dec 18, 2023

There is currently no notification for source string being changed. Closest to that is "Unfinished strings exist" as that will trigger when some string will need a translation.

@laoneo
Copy link
Author

laoneo commented Dec 18, 2023 •
edited

Any plan to integrate this? Coming from Transifex this is one of the key features, as rarely no translators are polling weblate for changes. It keeps them engaged.

@nijel
Copy link
Member

nijel commented Dec 18, 2023

This seems like a duplicate of #5602. Can you please review that and close this if this is really the case?

@laoneo
Copy link
Author

laoneo commented Dec 19, 2023

Not really, mine is more about notifications and not about pending tasks.

@laoneo
Copy link
Author

laoneo commented Dec 19, 2023

Or is there another way a translator who watches a project gets a notification when a source string has change or is added?

@Aga-C
Copy link
Contributor

Aga-C commented Dec 19, 2023

@nijel @laoneo I can confirm that it's a bug. I haven't changed anything in the settings, but some time ago, I stopped receiving any emails about new strings to translate or that someone translated something. I am only receiving notifications about new comments or new components.

@nijel
Copy link
Member

nijel commented Dec 19, 2023

@laoneo The notification for new string is there (New string is available for translation), the notification when source string changes is not there.

@Aga-C Unfortunately, we're not talking about a bug here, but about a missing feature. If you see a bug, please open a separate issue for that and provide more information (especially what notifications you have configured).

@laoneo
Copy link
Author

laoneo commented Dec 19, 2023

Thanks @nijel , but I do not get a mail when a new string is added either after a git rebase from the github webhook.

@laoneo
Copy link
Author

laoneo commented Dec 19, 2023 •
edited

@nijel how big is the chance that you will implement this feature request that when a source string is update that notification mails are going out? With this change you can catch up to the big providers like transifex or crowdin as this is an important feature to keep the translators engaged.

@laoneo
Copy link
Author

laoneo commented Dec 19, 2023

@laoneo The notification for new string is there (New string is available for translation), the notification when source string changes is not there.

This doesn't work on self hosted weblate. Should I open a bug report for this? Just that I do not miss here something. I'm adding a new string to the monolingual file and push it to the git repo. Then weblate updates but no mail is going out that there are new strings available for translation.

nijel added a commit to nijel/weblate that referenced this issue Dec 19, 2023
@nijel
change: add separate event for new string from the repo
5c8cbcb 
This makes the history more clear (it doesn't start with "String changed
in the repository") and allows to trigger new string notification on
such event.

See WeblateOrg#10651
@nijel nijel mentioned this issue Dec 19, 2023
Merged
5 tasks
@nijel
Copy link
Member

nijel commented Dec 19, 2023

You're right, the strings added in the repository do not trigger the notification, #10659 should address this.

nijel added a commit that referenced this issue Dec 19, 2023
@nijel
change: add separate event for new string from the repo
ac583c7 
This makes the history more clear (it doesn't start with "String changed
in the repository") and allows to trigger new string notification on
such event.

See #10651
@nijel nijel added this to the 5.4 milestone Dec 22, 2023
@laoneo laoneo mentioned this issue Dec 29, 2023
Closed
2 tasks
@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot added the wontfix Nobody will work on this. label Jan 6, 2024
@nijel nijel added enhancement Adding or requesting a new feature. and removed wontfix Nobody will work on this. labels Jan 6, 2024
@kvikshaug
Copy link

@nijel is it possible the issue wasn't completely solved? I'm testing locally version 5.3.1+2024-01-31 (which includes #10659). Adding a new string to the repo still does not trigger the notification, even though the setting New string is available for translation is set to Instant notification. (I do get a Repository operation notification.)

Rolling back to version 4.18.2 works. That is, with the same app data folder and database, adding a new string to the repo successfully sends a New string to translate notification.

@nijel
Copy link
Member

nijel commented Jan 31, 2024 •
edited

The issue indeed isn't completely solved as it is still open.

Do you see "String added in the repository" event in the string history?

@kvikshaug
Copy link

Ahh... I see. Yes indeed, the event is there:
image

@nijel nijel modified the milestones: 5.4, 5.5 Feb 13, 2024
nijel added a commit to nijel/weblate that referenced this issue Feb 14, 2024
@nijel
change: use post_save signal to trigger notifications
d60b93b 
This way it is also triggered via bulk_create and thus for events that
were created during repository update. We reuse post_save emitting logic
which is already present in bulk_create for the fedora messaging
integration.

See WeblateOrg#10651
@nijel nijel mentioned this issue Feb 14, 2024
Merged
5 tasks
@nijel
Copy link
Member

nijel commented Feb 14, 2024

#11002 should fix the new string notification not being sent.

nijel added a commit that referenced this issue Feb 14, 2024
@nijel
change: use post_save signal to trigger notifications
89aa32d 
This way it is also triggered via bulk_create and thus for events that
were created during repository update. We reuse post_save emitting logic
which is already present in bulk_create for the fedora messaging
integration.

See #10651
@laoneo
Copy link
Author

laoneo commented Feb 15, 2024

Thanks, so only update is missing and then can this issue being closed?

@nijel
Copy link
Member

nijel commented Feb 15, 2024

Yes.

@laoneo
Copy link
Author

laoneo commented Feb 15, 2024

Ok, then I wait with closing this issue.

@nijel nijel modified the milestones: 5.5, 5.6 Apr 17, 2024
nijel added a commit to nijel/weblate that referenced this issue May 15, 2024
@nijel
feat(notifications): add notification on strings needing updating
4387413 
Fixes WeblateOrg#10651
@nijel nijel mentioned this issue May 15, 2024
Merged
5 tasks
nijel added a commit to nijel/weblate that referenced this issue May 15, 2024
@nijel
feat(notifications): add notification on strings needing updating
eff2f28 
Fixes WeblateOrg#10651
@nijel nijel self-assigned this May 15, 2024
nijel added a commit to nijel/weblate that referenced this issue May 15, 2024
@nijel
feat(notifications): add notification on strings needing updating
e0c37a9 
Fixes WeblateOrg#10651
nijel added a commit that referenced this issue May 15, 2024
@nijel
feat(notifications): add notification on strings needing updating
0cef5af 
Fixes #10651
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
5.6
Development

Successfully merging a pull request may close this issue.

feat(notifications): add notification on strings needing updating nijel/weblate
4 participants
@kvikshaug @nijel @laoneo @Aga-C