Implement automated cleanup of unused glossary languages #11189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
requested changes
Mar 21, 2024
| @@ -28,6 +28,29 @@ def sync_glossary_languages(pk: int, component: Component | None = None): | |||
| ) | |||
| if not missing: | |||
| return | |||
|
|
|||
| # Identify unnecessary empty glossary languages | |||
There was a problem hiding this comment.
This would be executed only in case some languages are missing, see the above condition.
| @@ -28,6 +28,29 @@ def sync_glossary_languages(pk: int, component: Component | None = None): | |||
| ) | |||
| if not missing: | |||
| return | |||
|
|
|||
| # Identify unnecessary empty glossary languages | |||
| empty_glossary_languages = set(component.glossary_languages.all()) - set( | |||
There was a problem hiding this comment.
AttributeError: 'Component' object has no attribute 'glossary_languages'.
|
|
||
| # Identify unnecessary empty glossary languages | ||
| empty_glossary_languages = set(component.glossary_languages.all()) - set( | ||
| component.translations.filter(glossary_entries__isnull=False).values_list( |
There was a problem hiding this comment.
There is no such field glossary_entries.
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit implements a solution to identify and remove unnecessary empty glossary languages in the translation tool. It calculates a set of empty glossary languages by comparing the set of all glossary languages associated with a component to the set of languages with non-empty glossary entries in its translations. The identified empty glossary languages are then removed from the component.
Additionally, this commit addresses the removal of translation languages and their associated glossary languages. It identifies removed translation languages and iterates through their associated glossary languages, removing them from the component.
These changes streamline the management of glossary languages and ensure that only relevant languages are retained in the system.
Checklist
Other information
Fixes: #11168