Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSPageRule to inherit from CSSGroupingRule #346

Open
mstensho opened this issue May 9, 2024 · 4 comments
Open

CSSPageRule to inherit from CSSGroupingRule #346

mstensho opened this issue May 9, 2024 · 4 comments
Assignees
Labels
topic: css Spec relates to CSS (Cascading Style Sheets) venue: W3C CSS WG

Comments

@mstensho
Copy link

mstensho commented May 9, 2024

WebKittens

No response

Title of the spec

CSSOM: CSSPageRule to inherit from CSSGroupingRule

URL to the spec

https://www.w3.org/TR/cssom-1/#the-csspagerule-interface

URL to the spec's repository

No response

Issue Tracker URL

No response

Explainer URL

No response

TAG Design Review URL

No response

Mozilla standards-positions issue URL

No response

WebKit Bugzilla URL

No response

Radar URL

No response

Description

This is what the spec says. CSSPageRule should inherit from CSSGroupingRule, not directly from CSSRule - in order to support CSSMarginRule children.
Mozilla is about to ship this change: https://bugzilla.mozilla.org/show_bug.cgi?id=1868215
We want to do this in Chromum: https://groups.google.com/a/chromium.org/g/blink-dev/c/GcVSUIG9BGk

How about WebKit?

@annevk
Copy link
Contributor

annevk commented May 13, 2024

This seems fine. @mdubet thoughts?

@annevk annevk added topic: css Spec relates to CSS (Cascading Style Sheets) venue: W3C CSS WG labels May 13, 2024
@Ahmad-S792
Copy link

@mdubet
Copy link

mdubet commented May 22, 2024

Seems reasonable. Note that this will be the first example of a class inheritingCSSGroupingRule which doesn't accept a style rule as a child it seems ?

@mstensho
Copy link
Author

mstensho commented May 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: css Spec relates to CSS (Cascading Style Sheets) venue: W3C CSS WG
Projects
None yet
Development

No branches or pull requests

4 participants