Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPE][cross-toolchain-helper] Add chromium to webkitdevci images, port to scarthgap yocto release #30143

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[WPE][cross-toolchain-helper] Add chromium to webkitdevci images, port to scarthgap yocto release #30143

merged 1 commit into from
Jun 28, 2024

Conversation

nikolaszimmermann
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann commented Jun 25, 2024 •
edited by webkit-early-warning-system
Loading

9c523c6

[WPE][cross-toolchain-helper] Add chromium to webkitdevci images, port to scarthgap yocto release
https://bugs.webkit.org/show_bug.cgi?id=275846

Reviewed by Carlos Alberto Lopez Perez.

- Port rpi/riscv targets to latest yocto release (scarthgap)
- Include Chromium in the webkitdevci image for the rpi targets, for performance comparisions.
  Therefore we need a recent clang version - the mickledore yocto release is not sufficient.
  Furthermore we want to build chromium in the most "fair" way, not using some GCC flavour,
  but strictly following upstream recommendations, to end up with an unbiased comparision.

Covered by CI test infrastructure.

* Tools/yocto/meta-openembedded_and_meta-webkit.patch: Added.
* Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch: Removed.
* Tools/yocto/riscv/manifest.xml:
* Tools/yocto/rpi/bblayers.conf:
* Tools/yocto/rpi/local-rpi3-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi3-32bits-userland.conf:
* Tools/yocto/rpi/local-rpi3-64bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-64bits-mesa.conf:
* Tools/yocto/rpi/manifest.xml:
* Tools/yocto/targets.conf:

Canonical link: https://commits.webkit.org/280438@main

9ff9ac0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann self-assigned this Jun 25, 2024
@nikolaszimmermann nikolaszimmermann added the WPE WebKit WebKit WPE component label Jun 25, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 48f841d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann
Copy link
Contributor Author

Still a draft, need to test this.

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 48f841d to 09a4366 Compare June 25, 2024 11:23
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 09a4366)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 09a4366 to e6c2e20 Compare June 25, 2024 11:42
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash e6c2e20)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from e6c2e20 to 2fe4766 Compare June 26, 2024 07:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 2fe4766)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann requested a review from clopez June 26, 2024 07:52
@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 2fe4766 to 289fdb9 Compare June 26, 2024 07:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 289fdb9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 289fdb9 to 3dcf5dd Compare June 26, 2024 08:01
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 3dcf5dd)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 3dcf5dd to ad61d98 Compare June 26, 2024 08:03
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ad61d98)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann
Copy link
Contributor Author

NOTE: The netdata apps_groups.conf has been migrated to the repo which hosts the buildbot/ews scripts for the WebKit Perf bots, doesn't need to be part of the yocto definitions.

@nikolaszimmermann nikolaszimmermann requested a review from clopez June 26, 2024 09:52
@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from ad61d98 to 28ecd29 Compare June 26, 2024 09:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 28ecd29)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann
Copy link
Contributor Author

I didn't include chromium for the riscv target, not needed there, but properly ported all targets to scarthgap.

@clopez
Copy link
Contributor

clopez commented Jun 26, 2024

I didn't include chromium for the riscv target, not needed there, but properly ported all targets to scarthgap.

yes, that make sense.
Also is likely it will give build issues on that target.

@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 28ecd29 to 5bc7779 Compare June 26, 2024 11:14
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 5bc7779)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann
Copy link
Contributor Author

Worked: NOTE: Tasks Summary: Attempted 12163 tasks of which 12074 didn't need to be rerun and all succeeded.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2024
@clopez
Copy link
Contributor

clopez commented Jun 27, 2024

Thanks!
Let's try this

@clopez clopez removed the merging-blocked Applied to prevent a change from being merged label Jun 27, 2024
@nikolaszimmermann nikolaszimmermann force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 5bc7779 to 9ff9ac0 Compare June 27, 2024 21:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2024 •
edited
Loading

EWS run on current version of this PR (hash 9ff9ac0)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann added the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 9ff9ac0 to 4dfd0f3 Compare June 28, 2024 00:38
@nikolaszimmermann
[WPE][cross-toolchain-helper] Add chromium to webkitdevci images, por…
9c523c6 
…t to scarthgap yocto release

https://bugs.webkit.org/show_bug.cgi?id=275846

Reviewed by Carlos Alberto Lopez Perez.

- Port rpi/riscv targets to latest yocto release (scarthgap)
- Include Chromium in the webkitdevci image for the rpi targets, for performance comparisions.
  Therefore we need a recent clang version - the mickledore yocto release is not sufficient.
  Furthermore we want to build chromium in the most "fair" way, not using some GCC flavour,
  but strictly following upstream recommendations, to end up with an unbiased comparision.

Covered by CI test infrastructure.

* Tools/yocto/meta-openembedded_and_meta-webkit.patch: Added.
* Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch: Removed.
* Tools/yocto/riscv/manifest.xml:
* Tools/yocto/rpi/bblayers.conf:
* Tools/yocto/rpi/local-rpi3-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi3-32bits-userland.conf:
* Tools/yocto/rpi/local-rpi3-64bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-64bits-mesa.conf:
* Tools/yocto/rpi/manifest.xml:
* Tools/yocto/targets.conf:

Canonical link: https://commits.webkit.org/280438@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch from 4dfd0f3 to 9c523c6 Compare June 28, 2024 00:40
@webkit-commit-queue
Copy link
Collaborator

Committed 280438@main (9c523c6): https://commits.webkit.org/280438@main

Reviewed commits have been landed. Closing PR #30143 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9c523c6 into WebKit:main Jun 28, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2024
@nikolaszimmermann nikolaszimmermann deleted the eng/WPEcross-toolchain-helper-Add-chromium-to-webkitdevci-images-port-to-scarthgap-yocto-release branch June 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clopez clopez clopez approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@nikolaszimmermann nikolaszimmermann

Labels
WPE WebKit WebKit WPE component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikolaszimmermann @webkit-early-warning-system @clopez @webkit-commit-queue @webkit-ews-buildbot