-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document / validate positive value for block_for #38
Labels
Comments
It would be very nice to document the purpose of |
if anyone reading this is wondering : as far as I can understand from the source code, when a first call to throttle! fails the throttler will block for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
I noticed that if you use
0
as a value forblock_for
, then Redis raises the exceptionERR invalid expire time in setex
as soon as a request gets throttled. That is caused byblock_duration
reaching 0 here andsetex
failing.it would be nice to have validation for
block_for
or some additional documentation.The text was updated successfully, but these errors were encountered: