Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Magic Analytics disruptive #2151

Closed
mergd opened this issue Apr 14, 2024 · 7 comments
Closed

[bug] Magic Analytics disruptive #2151

mergd opened this issue Apr 14, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mergd
Copy link

mergd commented Apr 14, 2024

Requirement

  • If the customer does not enable Email and/or Social login, then the Magic SDK and Magic analytics should not run

Summary

The magic integration creates a lot of requests to Datadog, Vercel, and Segment for data analytics.

I have uBlock origin on, and it clutters up the console log with blocking errors as it keeps trying to post to the analytics endpoint. The easiest fix is to disable my adblocker on localhost, but Magic should also do better and cap the number of retries – especially if its something peripheral like analytics

CleanShot 2024-04-13 at 23 45 49@2x

List of related npm package versions

"@web3modal/siwe": "^4.1.6",
"@web3modal/wagmi": "^4.1.6",
@mergd mergd added bug Something isn't working needs review labels Apr 14, 2024
Copy link

linear bot commented Apr 14, 2024

@TipToe888
Copy link

Agreed this is extremely annoying although in production those errors go away

@cen1
Copy link

cen1 commented May 27, 2024

Same here but on top of that, enableAnalytics: false does not seem to disable it.

@RJKerry
Copy link

RJKerry commented Jul 24, 2024

Any updates on this?
image

@ayv8er
Copy link

ayv8er commented Aug 6, 2024

Magic here, those calls are very important to us.
But if you're blocking them anyways, capping after a number of retries make sense...
Let me bring this up with our team.

@ayv8er
Copy link

ayv8er commented Sep 13, 2024

Hi all, we've disabled analytics on AppKit.
Tested on our end, but would love for you to confirm as well @mergd ?

@rtomas
Copy link
Contributor

rtomas commented Sep 14, 2024

Please update to latest version to solve this issue

@linear linear bot closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants