Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats the startTime of a softnav? #14

Closed
paulirish opened this issue Feb 17, 2023 · 21 comments
Closed

Whats the startTime of a softnav? #14

paulirish opened this issue Feb 17, 2023 · 21 comments
Labels

Comments

@paulirish
Copy link

Looking at the impl in Blink it looks like it's a DOMHighResTimeStamp that's just a tad before Event Timing's processingStart.. essentially right before the event handlers execute.

But I'm wondering if it should be more like Event Timing's startTime which is the "hardware" timestamp of the event.. ?

The two relevant bits from event timing:

The timestamp at which the event was created can be obtained via the event’s timeStamp. In addition, performance.now() could be called both at the beginning and at the end of the event handler logic. By subtracting the hardware timestamp from the timestamp obtained at the beginning of the event handler, the developer can compute the input delay: the time it takes for an input to start being processed.
[...]
An Event's delay is the difference between the time when the browser is about to run event handlers for the event and the Event's timeStamp. The former point in time is exposed as the PerformanceEventTiming's processingStart, whereas the latter is exposed as PerformanceEventTiming's startTime. Therefore, an Event's delay can be computed as processingStart - startTime.

A trace showing where the timestamp currently is. The timestamp used for the softnav perfEntry === the SoftNavigationHeuristics::UserInitiatedClick event.

image

@paulirish
Copy link
Author

Ah, I found 1369680 - SoftNavigationEntry timestamp should be the click event start - chromium which has this discussion.

I'm reading mocny's argument as: hard navs don't start with the hardware timestamp of the event that triggered... so.. we shouldn't do the same for softnavs.

It seems reasonable, but I don't think I agree. IMO consistency alone isn't a good enough reason. (At the very least, I agree with yoav's "ideally, we'd expose the hardware timestamp numbers for both soft navigations and MPA followup navigations")

Using the user-centric framing…
image

FCP is the "Is it happening?" moment where the user gets feedback that the navigation has successfully begun. The payoff is the paint, and the start of that is the start of the interaction.

The case of massive input delay just means that the user's click has a big interaction latency until paint.. but IMO the fact that the cost is in input delay and not eventProcessing doesn't seem relevant to them. So the most user-centric POV of a softnav should start with the hardware timestamp.

@mmocny
Copy link

mmocny commented Mar 7, 2023

Valid points.

What about more complex cases, like this situation:

  • User interacts
  • Event handler runs, starts a soft-navigation, with fetch(), but doesn't apply history change yet
  • Handler updates the current UI immediately with some loading indicator, so INP triggers quickly.
  • Fetch() resolves successfully, and the site checks if the soft-nav has been cancelled (i.e. by a new interaction). It hasn't, so the new route DOM update is applied. FCP fires, LCP is in flight.

For conext, CLS would (currently, at least) use the processing start time of the event in order to set its 500ms hadRecentInput window.

I agree it would be good if all of CLS, INP, FCP/LCP started at the same time point. I do agree that for a User, the "latency" starts with timeStamp -- especially so for SPA or Same-origin MPA navigations... but it feels odd to blame the next origin document FCP for the previous origin Input Delay... (I know, we sorta do already for unload, redirects...).

Maybe we don't need to be consistent, but there's lots we'd need to change to be ideal...

@mmocny
Copy link

mmocny commented Mar 7, 2023

Oh, and, we have some efforts ongoing to make INP measure only up to the start of the new navigation-- so in my mind we would have:

INP (outgoing interaction) --> FCP (incoming navigation).

So any "navigation" needs to be 200+1500 ms at most, with yielding/rendering feedback at least once in between. That seems consistent with MPA, at least.

With that perspective, Soft-nav FCP should actually start even later, after INP stops measurement...

@yoavweiss
Copy link
Collaborator

Apologies for not chiming-in earlier..

I think that we have a couple of conflicting arguments here:

  • As Paul says, if we look at it from a user centric perspective, the HW timestamp is the point where the user tried to make something happen.
  • As Michal argues, if we want to compare soft navigations to hard navigations, we need to start measuring both from the same conceptual timestamp.

Looking at what we're doing for hard navigations, it seems like we're starting their time origin around creating a new browsing context.

(as an aside, it's not immediately obvious to me how that timestamp related to creating navigation params by fetching which seems to be what implementations are doing. ^^ @noamr)

In any case, I believe the relevant timestamp for hard navigations is after the initial event handler (e.g. for an <a> element's "click" event on the previous page) fired, and the browser was notified by the renderer that it's navigating. As such, the event start time seems to have better equivalence.

Moving both of those timestamps to the hardware timestamp would be ideal, but would also present many practical challenges:

  • We'd need to update all the dashboards currently looking at any metric
  • The timestamp itself and the difference between it and fetch start would leak cross-origin data. (the previous origin's event handling times)

@yoavweiss
Copy link
Collaborator

@paulirish - thoughts on the above? Do you think we can close this?

@mmocny
Copy link

mmocny commented Nov 10, 2023

Throwing in one more option: beforeunload event timing could be a useful model to look at (see: w3c/navigation-timing#190).

It is already well specced relative to interactions that would start navigations. For Same Origin document navigations -- which is what we are comparing for soft-navs -- my understanding is that the end of beforeunload event is (more or less?) the timeOrigin for the incoming page.

I know soft-navs won't actually fire that event, so I just mean to use as a model. I think the navigation API, when it intercepts the navigation, is basically the equivalent?


Another advantage of using that timestamp (i.e. one that follows the end of interaction processing) is that it makes it easier to slice the page timeline based on timestamps alone. Any entry (layout shift, event timing, etc) which preceded the start of the soft-nav you can be sure were from the previous route. If you use the Event timeStamp, even though it might capture User Experience, there becomes an overlapping amount of time where you are still on the previous route (i.e. the input delay portion, at the very least, but event processing + navigation event scheduling as well).

Given that INP already measures the latency of the "last" interaction with the previous route, I think its fine to say that navigation latency is INP+LCP and that you have 200ms to respond and 2.5s to load.

@noamr
Copy link

noamr commented Nov 16, 2023

Navigation timing doesn't use the time after beforeunload anymore, but rather the startTime of the fetch, as it's almost the same timestamp and makes it equivalent to resource timing.

ATM I can't think of a good conceptual equivalent in SPA - in both of them there could be some client-side processing in an event handler before we even know it's a navigation (think of a click handler that runs some JS before setting location.href.

We can't use anything like the beforeunload scenario etc because this is not a navigation in the HTML standard sense (assuming we're not using the navigation API) - all we're doing is responding to a UI event and changing the DOM+URL, and we're deriving from that that this is a "navigation".

Side note, there's a misconception that somehow the start time of navigation timing correlates directly with UX, but because of the above this is only true in some of the cases.

@yoavweiss
Copy link
Collaborator

In my view, the timestamp of the event that handles the user interaction (which is the currently defined behavior) is a reasonable compromise between the two extremes of hardware timestamp on the one hand, and start of the relevant fetch() on the other.

If y'all disagree, I'm happy to take concrete suggestions :)

@noamr
Copy link

noamr commented Nov 17, 2023

In my view, the timestamp of the event that handles the user interaction (which is the currently defined behavior) is a reasonable compromise between the two extremes of hardware timestamp on the one hand, and start of the relevant fetch() on the other.

Sounds reasonable, but it comes down to whether you want to compare between soft and hard navigations. I think with this model you can't in many scenarios.

@yoavweiss
Copy link
Collaborator

I think with this model you can't in many scenarios.

Is there a model with which it is possible?

@noamr
Copy link

noamr commented Nov 17, 2023

I think with this model you can't in many scenarios.

Is there a model with which it is possible?

I guess not. This is OK then.

@mmocny
Copy link

mmocny commented Nov 21, 2023

I continue to think that navigation UX should be considered as a combo of outgoing INP (after all, the outgoing page should still provide feedback for the interaction) + incoming FCP/LCP.

With that perspective, starting timeOrigin at the processingStart time of the event handler feels too early, given that it overlaps with what is already measured by INP. Yes, some setup may be kicked off there but substantial work should be deferred until after-next-paint and good SPAs do that by default. (i.e. defer incoming route rendering at least one animation frame, potentially with a transition).

INP likely needs to change slightly, and should stop at first visual feedback, which for navigations may not necessarily be Next Paint. It may suffice to consider URL change / UA loading spinners as sufficient to mark the transition point, which is why I think that navigate event is the right time point (the equivalent of beforeUnload).

For MPA navigations INP is moving in that direction as well: it should end measurement if page lifecycle events ("unload") fire before next paint has a chance.

@mmocny
Copy link

mmocny commented Nov 21, 2023

Hmmm, I realize now that only works for cases of eager URL updates, which is the model the navigate event supports when used to intercept 'semantic' navigations like <a> clicks, etc.

But in the case where a navigation is a custom click handler + preventDefault, the url change could be applied lazily. In those cases navigate is too late. Then I guess you do need to fallback to the original input event timing (via task attribution).

Is this correct?:
Screenshot 2023-11-21 at 10 32 20

If so, perhaps:

  • navigate event (if the task with UI event navigates)
  • processingEnd (if the task with the UI event, doesn't navigate)

But I can see the appeal of just using processingStart to keep it simple.

@mmocny
Copy link

mmocny commented Nov 23, 2023

After some discussion and testing, there seems to be agreement in the direction of adjusting the soft-nav startTime to be either:

  • interaction event processingEnd, or
  • navigateEvent processingEnd

In some local testing, this seems to match perceived UX well, seems useful for attribution (i.e. the INP vs FCP/LCP split), and has a nice measurement symmetry with MPA navigations.

(we may want to double check exactly which time point to use for navigate event. Perhaps the intercept time could differ from processingEnd time?)

@mmocny
Copy link

mmocny commented Nov 23, 2023

I have been doing some local testing with the following:

Add this to the outgoing page:

function cleanTime(ms = performance.timeOrigin + performance.now()) {
  return ms.toLocaleString(undefined, { maximumFractionDigits: 2 });
}

function block(ms) {
    const target = performance.now() + ms;
    while (performance.now() < target);
}

// Note: console doesn't work from page lifecycle events.
function longEvent(event) {
  console.log(event.type, "start", cleanTime());
  block(1000);
  localStorage['Soft.'+event.type] = cleanTime();
  console.log(event.type, "end", cleanTime());
}

navigation.addEventListener('navigate', longEvent);
window.addEventListener('pagehide', longEvent);
document.addEventListener('visibilitychange', longEvent);

console.log('timeOrigin', cleanTime(performance.timeOrigin));

Then I navigate around cross origin and same origin, injecting that snipped and comparing the next page timeOrigin to the previous page navigateEnd.

I try variants of navigations:

  • <a> clicks
  • form submit
  • window.location changes
  • history.pushState

...and it seems fairly consistent that navigate end is a reasonable and consistent timeOrigin for navigations.

@yoavweiss
Copy link
Collaborator

While implementing this, a question (read: failing test) has come up:
When there's a click event handler that then called history.back() and triggers a popstate event, which of these events should set the timestamp as its processing end?

I'd argue that in that case, it's the click event that should be set. But I'd love your thoughts if you think that's wrong.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 24, 2023
This CL aligns the implementation with [1], and sets the soft navigation
start time to be the processingEnd of the relevant earlier event.

It also cleans up a few bits of code that became useless, as well as
issues around PerInteractionData copying that were buggy yet hidden
before the timing of setting the different attributes was changed.

[1] WICG/soft-navigations#14

Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
Bug: 1505059
@mmocny
Copy link

mmocny commented Nov 24, 2023

Net/net, I think it still fits the model of "event processingEnd" or "navigate event end", whichever comes first.


I just tested locally, and I noticed that the behaviour of back() appears to differ for same-origin and cross-origin navigations (cross-document), and seems also to differ even further for SPA (at least a few I tested).

  • For XO: The new page will start loading immediately (as the renderer gets replaced immediately). This is same as using window.location to go forward.
  • For SO, cross document: Will wait for click event processing to finish, and also for page lifecycle events to fire-- but it seems the navigate event doesn't fire? (why?[1])
  • For SO, same document: Similar to above, but navigate event does fire now. It gets scheduled as a separate task following event processingEnd. I saw this on a few different SPA, but I wouldn't be surprised if it depended on how the router implements links/navigations.

I think this is somewhat equivalent to using window.location for forward navigations?

Unlike pushState(), which will dispatch synchronously from the middle of the event handlers, and update URL and fire navigate event, which back() and location = href will schedule those events to fire after event processing, and delay URL update.

I think that means its consistent.


[1]: I also thought that there were some conventions/interventions about being able to intercept/observe specific to back navigations: e.g. maybe you can intercept once per new user interaction with a page, and so maybe that explains some of the nav event firing order? However, I'm not seeing any difference if I interact with the web content first or not. I may not be testing perfectly.

@mmocny
Copy link

mmocny commented Nov 24, 2023

Oh, maybe your point was that the navigation doesn't "actually start" until popstate event is scheduled, and so we could choose to treat that event as "the event" instead of the click?

I think I agree that click event is still the right one.

Although I suspect most pages won't actually start rendering until popstate fires, and URL doesn't update until it does, I would consider this a type of "TTFB" for the navigation. This delay won't be captured by INP (or isn't guaranteed to, anyway)

@yoavweiss
Copy link
Collaborator

Oh, maybe your point was that the navigation doesn't "actually start" until popstate event is scheduled, and so we could choose to treat that event as "the event" instead of the click?

I think I agree that click event is still the right one.

That was indeed my question! I'm glad we agree :)

@yoavweiss
Copy link
Collaborator

This is now closed by 1111c03, so closing! Thanks for the discussion!!

@yoavweiss
Copy link
Collaborator

Also, https://chromium-review.googlesource.com/c/chromium/src/+/5059108 is the Chromium implementation change to align with this.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 24, 2023
This CL aligns the implementation with [1], and sets the soft navigation
start time to be the processingEnd of the relevant earlier event.

It also cleans up a few bits of code that became useless, as well as
issues around PerInteractionData copying that were buggy yet hidden
before the timing of setting the different attributes was changed.

[1] WICG/soft-navigations#14

Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
Bug: 1505059
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 27, 2023
This CL aligns the implementation with [1], and sets the soft navigation
start time to be the processingEnd of the relevant earlier event.

It also cleans up a few bits of code that became useless, as well as
issues around PerInteractionData copying that were buggy yet hidden
before the timing of setting the different attributes was changed.

[1] WICG/soft-navigations#14

Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
Bug: 1505059
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 28, 2023
This CL aligns the implementation with [1], and sets the soft navigation
start time to be the processingEnd of the relevant earlier event.

It also cleans up a few bits of code that became useless, as well as
issues around PerInteractionData copying that were buggy yet hidden
before the timing of setting the different attributes was changed.

[1] WICG/soft-navigations#14

Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
Bug: 1505059
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Dec 13, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Revert "[soft-navigations] move startTime to processing end"

This reverts commit eab7d4b6462aee496860f0dbe342066bd342f5b9.

Reason for revert: Introduced errors in tast tests blocking Uprev and LKGM.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059, 1506273
Change-Id: Ia6655f4e010ba613a4880be1a89cb8319593fbc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074932
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Matthew Mourgos <[email protected]>
Commit-Queue: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1230965}

--

wpt-commits: e568ead676f53a9d779efba1f30aec863e2edc13
wpt-pr: 43432
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Dec 13, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9

It better takes into account event bubbling, and the fact we see
multiple tasks in a single EventScope in those cases. It also tests this case specifically.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059
Change-Id: I8c3664588c937e91643651d86d5a9635433e8e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
Commit-Queue: Yoav Weiss <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1231299}

--

wpt-commits: 0b3dc935fcac323b0398b24b314e489aec49fb9d
wpt-pr: 43443
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Revert "[soft-navigations] move startTime to processing end"

This reverts commit eab7d4b6462aee496860f0dbe342066bd342f5b9.

Reason for revert: Introduced errors in tast tests blocking Uprev and LKGM.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059, 1506273
Change-Id: Ia6655f4e010ba613a4880be1a89cb8319593fbc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074932
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Owners-Override: Matthew Mourgos <mmourgosgoogle.com>
Commit-Queue: Matthew Mourgos <mmourgosgoogle.com>
Cr-Commit-Position: refs/heads/main{#1230965}

--

wpt-commits: e568ead676f53a9d779efba1f30aec863e2edc13
wpt-pr: 43432

UltraBlame original commit: 7714f6cd5ba35517a9cc6b72ecb82e5052ff0dab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9

It better takes into account event bubbling, and the fact we see
multiple tasks in a single EventScope in those cases. It also tests this case specifically.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059
Change-Id: I8c3664588c937e91643651d86d5a9635433e8e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Cr-Commit-Position: refs/heads/main{#1231299}

--

wpt-commits: 0b3dc935fcac323b0398b24b314e489aec49fb9d
wpt-pr: 43443

UltraBlame original commit: c6a6af6e5971373dca98aa050b273c6eebd55dce
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Revert "[soft-navigations] move startTime to processing end"

This reverts commit eab7d4b6462aee496860f0dbe342066bd342f5b9.

Reason for revert: Introduced errors in tast tests blocking Uprev and LKGM.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059, 1506273
Change-Id: Ia6655f4e010ba613a4880be1a89cb8319593fbc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074932
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Owners-Override: Matthew Mourgos <mmourgosgoogle.com>
Commit-Queue: Matthew Mourgos <mmourgosgoogle.com>
Cr-Commit-Position: refs/heads/main{#1230965}

--

wpt-commits: e568ead676f53a9d779efba1f30aec863e2edc13
wpt-pr: 43432

UltraBlame original commit: 7714f6cd5ba35517a9cc6b72ecb82e5052ff0dab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9

It better takes into account event bubbling, and the fact we see
multiple tasks in a single EventScope in those cases. It also tests this case specifically.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059
Change-Id: I8c3664588c937e91643651d86d5a9635433e8e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Cr-Commit-Position: refs/heads/main{#1231299}

--

wpt-commits: 0b3dc935fcac323b0398b24b314e489aec49fb9d
wpt-pr: 43443

UltraBlame original commit: c6a6af6e5971373dca98aa050b273c6eebd55dce
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Revert "[soft-navigations] move startTime to processing end"

This reverts commit eab7d4b6462aee496860f0dbe342066bd342f5b9.

Reason for revert: Introduced errors in tast tests blocking Uprev and LKGM.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059, 1506273
Change-Id: Ia6655f4e010ba613a4880be1a89cb8319593fbc8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074932
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Owners-Override: Matthew Mourgos <mmourgosgoogle.com>
Commit-Queue: Matthew Mourgos <mmourgosgoogle.com>
Cr-Commit-Position: refs/heads/main{#1230965}

--

wpt-commits: e568ead676f53a9d779efba1f30aec863e2edc13
wpt-pr: 43432

UltraBlame original commit: 7714f6cd5ba35517a9cc6b72ecb82e5052ff0dab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Dec 16, 2023
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9

It better takes into account event bubbling, and the fact we see
multiple tasks in a single EventScope in those cases. It also tests this case specifically.

Original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Bug: 1505059
Change-Id: I8c3664588c937e91643651d86d5a9635433e8e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Cr-Commit-Position: refs/heads/main{#1231299}

--

wpt-commits: 0b3dc935fcac323b0398b24b314e489aec49fb9d
wpt-pr: 43443

UltraBlame original commit: c6a6af6e5971373dca98aa050b273c6eebd55dce
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 9, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 10, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 12, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 12, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 15, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 15, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:

> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:

> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059
Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 15, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:

> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:

> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059
Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 16, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:

> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:

> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059
Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:

> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:

> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Bug: 1505059
Change-Id: Ib70187d5b6335d57705cc15b62a33e142884dd99
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
aarongable pushed a commit to chromium/chromium that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536, which was
reverted in ba0a09e.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 21, 2024
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}

--

wpt-commits: d9343559a872827412e7d911f690f96bd48881f6
wpt-pr: 43908
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jan 22, 2024
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <iclellandchromium.org>
Reviewed-by: Michal Mocny <mmocnychromium.org>
Cr-Commit-Position: refs/heads/main{#1248327}

--

wpt-commits: d9343559a872827412e7d911f690f96bd48881f6
wpt-pr: 43908

UltraBlame original commit: 7784ed9458d9977d2f45c678671e413f39f0516b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jan 22, 2024
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <iclellandchromium.org>
Reviewed-by: Michal Mocny <mmocnychromium.org>
Cr-Commit-Position: refs/heads/main{#1248327}

--

wpt-commits: d9343559a872827412e7d911f690f96bd48881f6
wpt-pr: 43908

UltraBlame original commit: 7784ed9458d9977d2f45c678671e413f39f0516b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jan 22, 2024
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Cr-Commit-Position: refs/heads/main{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <iclellandchromium.org>
Reviewed-by: Michal Mocny <mmocnychromium.org>
Cr-Commit-Position: refs/heads/main{#1248327}

--

wpt-commits: d9343559a872827412e7d911f690f96bd48881f6
wpt-pr: 43908

UltraBlame original commit: 7784ed9458d9977d2f45c678671e413f39f0516b
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Jan 23, 2024
…e to processing end", a=testonly

Automatic update from web-platform-tests
Reland "[soft-navigations] move startTime to processing end"

This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}

--

wpt-commits: d9343559a872827412e7d911f690f96bd48881f6
wpt-pr: 43908
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Feb 23, 2024
This is a reland of commit bc3a536a4fc930ff5161c7795758e72893b6afca, which was
reverted in ba0a09e0fca6c7e8e98ad168d52684e4b3f34a08.

Original change's description:
> Reland "[soft-navigations] move startTime to processing end"
>
> This is a reland of commit eab7d4b6462aee496860f0dbe342066bd342f5b9
>
> It better takes into account event bubbling, and the fact we see
> multiple tasks in a single EventScope in those cases. It also tests this case specifically.
>
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076713
> Commit-Queue: Yoav Weiss <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1231299}

Original original change's description:
> [soft-navigations] move startTime to processing end
>
> This CL aligns the implementation with [1], and sets the soft navigation
> start time to be the processingEnd of the relevant earlier event.
>
> It also cleans up a few bits of code that became useless, as well as
> issues around PerInteractionData copying that were buggy yet hidden
> before the timing of setting the different attributes was changed.
>
>
> [1] WICG/soft-navigations#14
>
> Change-Id: Id9f7ebf9f372a334a206f99258c882f10eeda2c5
> Bug: 1505059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5059108
> Reviewed-by: Ian Clelland <[email protected]>
> Commit-Queue: Yoav Weiss <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1230490}

Change-Id: I333de5e1f2bfb04106abf639ecbad7698cc5ea7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181596
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Michal Mocny <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1248327}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants