Skip to content

Should we require manifestid? #6

@mikewest

Description

@mikewest

Copy/pasting from @LiaHiscock's comments in #4 (comment):

"""
Re. the manifestid requirement, that doc looks a bit out of date. Let me try to clarify. Manifest id is an app's unique identifier, and how we determine if an app is already installed, should be updated, etc. Unfortunately, id is not a required manifest field, so only about 4% of apps declare one. For the other 96% of apps, we "compute" an id using the start_url field, see starbucks.com's 'application' tab.

starbucks.com's 'application' tab, showing a generated ID.

However, this opens the door for security issues, because if the developer changes their start_url, their site will appear to the browser as a completely new app that can be installed (multiple apps-foot-gun situation mentioned in Dan's doc), and existing installs under the former start_url become orphaned.

Dan was a big proponent of the id requirement for the API. IIRC our goal there was that the 2 parameter signature helps with backwards compatibility for existing apps without ids, and ideally the 1 parameter signature usage will grow as more apps adopt ids.
"""

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions