Skip to content

Refactor the SPS scripts to reduce the number of environment variables used #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yongja79 opened this issue May 23, 2025 · 0 comments

Comments

@yongja79
Copy link
Contributor

The scripts currently use many boolean environment variables in the 1P pipeline and the logic used in the scripts to determine the behaviour can be quite convoluted. The move to SPS gives an opportunity to simplify this.

Some of the current env variables which are generally booleans

  • SKIP_ACCCEPTANCE_TEST

  • SKIP_ALL_CHECKS

  • SKIP_BYOE_TEST

  • SKIP_CONTAINERIZE

  • SKIP_KIND_E2E_TEST

  • SKIP_OCP_E2E_TEST

  • SKIP_SCANS

  • airgap_run_test

  • periodic-rescan

  • release-acceptance-test

  • release

  • architecture

  • test_architecture

Possible changes into enums:

  • Accpetance Test
    • All
    • OCP
    • KIND
    • None
  • Special Tests
    • All
    • BYOE
    • Airgap
    • None
  • architecture
    • X
    • P
    • Z
    • All
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant