Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectionEvents.SelectionChanged does not fire due to exception in OnSelectionChanged in specific cases #426

Open
Jo8n opened this issue Apr 1, 2023 · 0 comments

Comments

@Jo8n
Copy link

Jo8n commented Apr 1, 2023

When the user selects a solution or a project after having selected the solution, an exception occurs in SolutionItem.FromHierarchy as called from SelectionEvents.OnSelectionChanged.

Would suggest changing these two lines in SelectionEvents.OnSelectionChanged:
SolutionItem? from = SolutionItem.FromHierarchy(pHierOld, itemidOld);
SolutionItem? to = SolutionItem.FromHierarchy(pHierNew, itemidNew);
to:
SolutionItem? from = pHierOld == null ? null : SolutionItem.FromHierarchy(pHierOld, itemidOld);
SolutionItem? to = pHierNew == null ? null : SolutionItem.FromHierarchy(pHierNew, itemidNew);

As an aside, thanks for a great toolkit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant