Skip to content

SelectionEvents.SelectionChanged does not fire due to exception in OnSelectionChanged in specific cases #426

Open
@Jo8n

Description

@Jo8n

When the user selects a solution or a project after having selected the solution, an exception occurs in SolutionItem.FromHierarchy as called from SelectionEvents.OnSelectionChanged.

Would suggest changing these two lines in SelectionEvents.OnSelectionChanged:
SolutionItem? from = SolutionItem.FromHierarchy(pHierOld, itemidOld);
SolutionItem? to = SolutionItem.FromHierarchy(pHierNew, itemidNew);
to:
SolutionItem? from = pHierOld == null ? null : SolutionItem.FromHierarchy(pHierOld, itemidOld);
SolutionItem? to = pHierNew == null ? null : SolutionItem.FromHierarchy(pHierNew, itemidNew);

As an aside, thanks for a great toolkit!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions