Skip to content

Commit 7494613

Browse files
author
David Inga
committed
Merge branch 'release/0.2.1'
* release/0.2.1: removed webpack import
2 parents 4945c3f + 3bae8d8 commit 7494613

File tree

7 files changed

+28
-20
lines changed

7 files changed

+28
-20
lines changed

components/Form/CheckboxGroup/index.jsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ class CheckboxGroup extends React.Component {
2626
const i = this.state.selected.indexOf(e.currentTarget.value);
2727

2828
// Toggle element from the array
29-
(i === -1) ?
30-
newSelected.push(e.currentTarget.value) :
29+
if (i === -1) {
30+
newSelected.push(e.currentTarget.value);
31+
} else {
3132
newSelected.splice(i, 1);
33+
}
3234

3335
// Set state
3436
this.setState({
@@ -38,7 +40,7 @@ class CheckboxGroup extends React.Component {
3840
const selectedArr = this.props.items.filter(item => (
3941
this.state.selected.indexOf(item.value) !== -1
4042
));
41-
this.props.onChange && this.props.onChange(selectedArr);
43+
if (this.props.onChange) this.props.onChange(selectedArr);
4244
});
4345
}
4446

@@ -48,8 +50,8 @@ class CheckboxGroup extends React.Component {
4850

4951
return (
5052
<div className={`c-checkbox-box ${this.props.className}`}>
51-
{items.map((item, i) => (
52-
<div key={i} className="c-checkbox">
53+
{items.map(item => (
54+
<div key={`c-checkbox-item-${name}`} className="c-checkbox">
5355
<input
5456
type="checkbox"
5557
name={name}

components/Form/RadioGroup/index.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class RadioGroup extends React.Component {
2929
});
3030

3131
// Trigger change selected if it's needed
32-
this.props.onChange && this.props.onChange(selectedObj);
32+
if (this.props.onChange) this.props.onChange(selectedObj);
3333
}
3434

3535
render() {
@@ -38,8 +38,8 @@ class RadioGroup extends React.Component {
3838

3939
return (
4040
<div className={`c-radio-box ${this.props.className}`}>
41-
{items.map((item, i) => (
42-
<div key={i} className="c-radio">
41+
{items.map(item => (
42+
<div key={`c-radio-item-${name}`} className="c-radio">
4343
<input
4444
type="radio"
4545
name={name}

components/Globe/index.jsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
import React from 'react';
22
import * as THREE from 'three';
33
import orbitControl from 'three-orbit-controls';
4-
import earthImage from './images/earth-clouds.jpg';
5-
import earthBumpImage from './images/earth-bump.jpg';
6-
import './style.scss';
74

85
const Control = orbitControl(THREE);
96

@@ -61,7 +58,7 @@ class GlobeComponent extends React.Component {
6158
addGlobe() {
6259
const material = new THREE.MeshPhongMaterial({
6360
map: this.imageLoader.load(this.props.basemapImage),
64-
bumpMap: this.imageLoader.load(earthBumpImage),
61+
bumpMap: this.imageLoader.load(this.props.earthBumpImage),
6562
bumpScale: 2
6663
});
6764
const geometry = new THREE.SphereGeometry(this.props.radius, 40, 30);
@@ -81,20 +78,26 @@ class GlobeComponent extends React.Component {
8178

8279
render() {
8380
return (
84-
<div ref={(node) => this.el = node} className="vizz-component-globe"></div>
81+
<div ref={(node) => { this.el = node; }} className="vizz-component-globe" />
8582
);
8683
}
8784

8885
}
8986

9087
GlobeComponent.defaultProps = {
91-
width: 500,
92-
height: 500,
9388
radius: 200,
9489
autorotate: true,
9590
velocity: 0.15,
96-
scrollTop: 0,
97-
basemapImage: earthImage
91+
scrollTop: 0
92+
};
93+
94+
GlobeComponent.propTypes = {
95+
radius: React.PropTypes.number,
96+
autorotate: React.PropTypes.bool,
97+
velocity: React.PropTypes.number,
98+
scrollTop: React.PropTypes.number,
99+
basemapImage: React.PropTypes.string,
100+
earthBumpImage: React.PropTypes.string
98101
};
99102

100103
export default GlobeComponent;

components/Modal/index.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React, { Component } from 'react';
2-
import './style.scss';
32

43
class Modal extends Component {
54

components/Spinner/index.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
import './style.scss';
32

43
function Spinner(props) {
54
return (

components/SvgIcon/index.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
import './style.scss';
32

43
export default function SvgIcon({ name, className }) {
54
return (

components/styles.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
@import 'Spinner/style';
2+
@import 'Globe/style';
3+
@import 'Modal/style';
4+
@import 'SvgIcon/style';
5+
@import 'Form/CheckboxGroup/style';
6+
@import 'Form/RadioGroup/style';

0 commit comments

Comments
 (0)