fixed issue when uploading same file under different name

Carsten Seeger · Carsten Seeger · commit e1dbb65ae364 · 2020-08-21T15:28:34.000+02:00
diff --git a/lib/mailparse.go b/lib/mailparse.go
@@ -213,9 +213,8 @@ func (m Mail2Most) parseAttachment(body []byte, header string) (Attachment, erro
 
 	sum := sha256.Sum256(body)
 	if _, ok := seenAttachments[sum]; ok {
-		// throwing an error here is a bit strange it would be better to return the existing attachment
 		// btw this could be exploited by creating a hash colision :D
-		return Attachment{}, errors.New("attachment already exists")
+		return Attachment{Filename: seenAttachments[sum], Content: body}, nil
 	}
 
 	seenAttachments[sum] = filename

Original file line number	Diff line number	Diff line change
`@@ -213,9 +213,8 @@ func (m Mail2Most) parseAttachment(body []byte, header string) (Attachment, erro`
`213`	`213`
`214`	`214`	`sum := sha256.Sum256(body)`
`215`	`215`	`if _, ok := seenAttachments[sum]; ok {`
`216`		`- // throwing an error here is a bit strange it would be better to return the existing attachment`
`217`	`216`	`// btw this could be exploited by creating a hash colision :D`
`218`		`- return Attachment{}, errors.New("attachment already exists")`
	`217`	`+ return Attachment{Filename: seenAttachments[sum], Content: body}, nil`
`219`	`218`	`}`
`220`	`219`
`221`	`220`	`seenAttachments[sum] = filename`