VCST-4673: Preserve System Context for Hangfire Background Jobs (#2982)

Author: OlegoO

src/VirtoCommerce.Platform.Data/Extensions/ApplicationBuilderExtensions.cs

@@ -5,7 +5,6 @@
 using VirtoCommerce.Platform.Core.ChangeLog;
 using VirtoCommerce.Platform.Core.Common;
 using VirtoCommerce.Platform.Core.Security;
-using static VirtoCommerce.Platform.Data.Constants.DefaultEntityNames;
 
 namespace VirtoCommerce.Platform.Data.Extensions
 {
@@ -33,13 +32,8 @@ public static IApplicationBuilder UseDbTriggers(this IApplicationBuilder appBuil
 
                 entry.Entity.CreatedDate = entry.Original.CreatedDate;
                 entry.Entity.CreatedBy = entry.Original.CreatedBy;
-
                 entry.Entity.ModifiedDate = currentTime;
-
-                if (userName != UNKNOWN_USERNAME)
-                {
-                    entry.Entity.ModifiedBy = userName;
-                }
+                entry.Entity.ModifiedBy = userName;
             };
 
             Triggers<IEntity>.Inserting += entry =>

src/VirtoCommerce.Platform.Hangfire/Middleware/HangfireUserContextMiddleware.cs

@@ -25,7 +25,9 @@ public HangfireUserContextMiddleware(IUserNameResolver userNameResolver)
         public void OnCreating(CreatingContext filterContext)
         {
             if (ContextUserName is null)
+            {
                 return;
+            }
 
             filterContext.SetJobParameter(USER_NAME, ContextUserName);
         }
@@ -41,7 +43,16 @@ public void OnCreated(CreatedContext filterContext)
 
         public void OnPerforming(PerformingContext filterContext)
         {
-            var userName = filterContext.GetJobParameter<string>(USER_NAME);
+            string userName;
+
+            if (IsRecurringJob(filterContext, out var recurringJobId))
+            {
+                userName = $"system:{recurringJobId}";
+            }
+            else
+            {
+                userName = filterContext.GetJobParameter<string>(USER_NAME);
+            }
 
             _userNameResolver.SetCurrentUserName(userName);
         }
@@ -52,5 +63,11 @@ public void OnPerformed(PerformedContext filterContext)
         }
 
         #endregion IServerFilter Members
+
+        private static bool IsRecurringJob(PerformingContext context, out string recurringJobId)
+        {
+            recurringJobId = context.GetJobParameter<string>("RecurringJobId");
+            return !string.IsNullOrEmpty(recurringJobId);
+        }
     }
 }

src/VirtoCommerce.Platform.Security/HttpContextUserResolver.cs

@@ -12,12 +12,14 @@ public class HttpContextUserResolver : IUserNameResolver
         /// <summary>
         /// This header contains logined user name
         /// </summary>
-        private const string CurrentUserNameHeader = "VirtoCommerce-User-Name";
+        private const string _currentUserNameHeader = "VirtoCommerce-User-Name";
 
         /// <summary>
         /// This header contains Login-on-behalf operator user name
         /// </summary>
-        private const string OperatorUserNameHeader = "VirtoCommerce-Operator-User-Name";
+        private const string _operatorUserNameHeader = "VirtoCommerce-Operator-User-Name";
+
+        private const string _anonymousUserName = "http:anonymous";
 
         private static readonly AsyncLocal<string> _currentUserName = new AsyncLocal<string>();
 
@@ -35,6 +37,8 @@ public string GetCurrentUserName()
             var context = _httpContextAccessor.HttpContext;
             if (context != null && context.Request != null && context.User != null)
             {
+                result = _anonymousUserName;
+
                 var identity = context.User.Identity;
                 if (identity != null && identity.IsAuthenticated)
                 {
@@ -44,9 +48,9 @@ public string GetCurrentUserName()
                     if (string.IsNullOrEmpty(result))
                     {
                         // Login-on-behalf operator user has a priority over an actual user
-                        var userHeader = context.Request.Headers.ContainsKey(OperatorUserNameHeader) ?
-                            OperatorUserNameHeader :
-                            CurrentUserNameHeader;
+                        var userHeader = context.Request.Headers.ContainsKey(_operatorUserNameHeader) ?
+                            _operatorUserNameHeader :
+                            _currentUserNameHeader;
 
                         result = context.Request.Headers[userHeader];
                         if (string.IsNullOrEmpty(result))