Skip to content

Commit be0cb6b

Browse files
dvs39ekuvirto
andauthored
feat: make some methods of BrowseFilterService protected (#759)
Co-authored-by: Kutasina Elena <[email protected]>
1 parent 2b9363e commit be0cb6b

File tree

3 files changed

+34
-38
lines changed

3 files changed

+34
-38
lines changed

src/VirtoCommerce.CatalogModule.Web/Model/AggregationProperty.cs renamed to src/VirtoCommerce.CatalogModule.Core/Model/AggregationProperty.cs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
1-
using System;
2-
using System.Collections.Generic;
3-
using System.Linq;
4-
5-
namespace VirtoCommerce.CatalogModule.Web.Model
6-
{
7-
public class AggregationProperty : ICloneable
8-
{
9-
public string Name { get; set; }
10-
public bool IsSelected { get; set; }
11-
public string Type { get; set; }
12-
public string Currency { get; set; }
13-
public int? Size { get; set; }
14-
public int ValuesCount => Values?.Count ?? 0;
15-
public IList<string> Values { get; set; }
16-
17-
public object Clone()
18-
{
19-
var result = (AggregationProperty)MemberwiseClone();
20-
result.Values = Values?.ToList();
21-
return result;
22-
}
23-
}
24-
}
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Linq;
4+
5+
namespace VirtoCommerce.CatalogModule.Core.Model
6+
{
7+
public class AggregationProperty : ICloneable
8+
{
9+
public string Name { get; set; }
10+
public bool IsSelected { get; set; }
11+
public string Type { get; set; }
12+
public string Currency { get; set; }
13+
public int? Size { get; set; }
14+
public int ValuesCount => Values?.Count ?? 0;
15+
public IList<string> Values { get; set; }
16+
17+
public object Clone()
18+
{
19+
var result = (AggregationProperty)MemberwiseClone();
20+
result.Values = Values?.ToList();
21+
return result;
22+
}
23+
}
24+
}

src/VirtoCommerce.CatalogModule.Data/Search/BrowseFilters/BrowseFilterService.cs

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ protected virtual async Task SaveSerializedValue(string storeId, string serializ
118118

119119

120120
// Support JSON for serialization
121-
private static string Serialize(IList<IBrowseFilter> filters)
121+
protected static string Serialize(IList<IBrowseFilter> filters)
122122
{
123123
string result = null;
124124

@@ -133,20 +133,18 @@ private static string Serialize(IList<IBrowseFilter> filters)
133133
};
134134

135135
// Serialize to JSON
136-
using (var memStream = new MemoryStream())
137-
{
138-
browsing.SerializeJson(memStream, _jsonSerializer);
139-
memStream.Seek(0, SeekOrigin.Begin);
136+
using var memStream = new MemoryStream();
137+
browsing.SerializeJson(memStream, _jsonSerializer);
138+
memStream.Seek(0, SeekOrigin.Begin);
140139

141-
result = memStream.ReadToString();
142-
}
140+
result = memStream.ReadToString();
143141
}
144142

145143
return result;
146144
}
147145

148146
// Support both JSON and XML for deserialization
149-
private static IList<IBrowseFilter> Deserialize(string value)
147+
protected static IList<IBrowseFilter> Deserialize(string value)
150148
{
151149
IList<IBrowseFilter> result = null;
152150

@@ -163,11 +161,9 @@ private static IList<IBrowseFilter> Deserialize(string value)
163161
else
164162
{
165163
// JSON
166-
using (var stringReader = new StringReader(value))
167-
using (var jsonTextReader = new JsonTextReader(stringReader))
168-
{
169-
browsing = _jsonSerializer.Deserialize<FilteredBrowsing>(jsonTextReader);
170-
}
164+
using var stringReader = new StringReader(value);
165+
using var jsonTextReader = new JsonTextReader(stringReader);
166+
browsing = _jsonSerializer.Deserialize<FilteredBrowsing>(jsonTextReader);
171167
}
172168

173169
// Flatten groups

src/VirtoCommerce.CatalogModule.Web/Controllers/Api/CatalogBrowseFiltersController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
using Microsoft.AspNetCore.Http;
88
using Microsoft.AspNetCore.Mvc;
99
using VirtoCommerce.CatalogModule.Core;
10+
using VirtoCommerce.CatalogModule.Core.Model;
1011
using VirtoCommerce.CatalogModule.Core.Model.Search;
1112
using VirtoCommerce.CatalogModule.Core.Search;
1213
using VirtoCommerce.CatalogModule.Core.Services;
1314
using VirtoCommerce.CatalogModule.Data.Search.BrowseFilters;
14-
using VirtoCommerce.CatalogModule.Web.Model;
1515
using VirtoCommerce.Platform.Core.Common;
1616
using VirtoCommerce.Platform.Core.Settings;
1717
using VirtoCommerce.StoreModule.Core.Model;

0 commit comments

Comments
 (0)