Skip to content

Latest commit

聽

History

History
131 lines (86 loc) 路 5.79 KB

CONTRIBUTING.md

File metadata and controls

131 lines (86 loc) 路 5.79 KB
Raw

馃 Contributing to Very Good CLI

First of all, thank you for taking the time to contribute! 馃帀馃憤 Before you do, please carefully read this guide.

Understanding Very Good CLI

Very Good CLI allows you to generate scalable templates and use helpful commands. These functionalities have been decomposed into different repositories and packages.

Templates have their own repositories, if you want to contribute to them please refer to their repositories:

If there are additional templates you'd like to see, open an issue and tell us!

馃挕 Note: Very Good CLI's completion functionality is powered by CLI Completion and its test command optimization is powered by test optimizer. If you want to contribute to either of those, please refer to their respective CONTRIBUTING files.

Opening an issue

We highly recommend creating an issue if you have found a bug, want to suggest a feature, or recommend a change. Please do not immediately open a pull request. Opening an issue first allows us to reach an agreement on a fix before you put significant effort into a pull request.

When reporting a bug, please use the built-in Bug Report template and provide as much information as possible including detailed reproduction steps. Once one of the package maintainers has reviewed the issue and we reach an agreement on the fix, open a pull request.

Developing for Very Good CLI

To develop for Very Good CLI you will need to become familiar with Very Good Ventures processes and conventions:

Setting up your local development environment

  1. Install a valid Flutter SDK in your local environment. Compatible Flutter SDK versions with Very Good CLI can be found here, ensure it has a Dart version compatible with Very Good CLI's Dart version constraint.

  2. Install all Very Good CLI's dependencies:

# 馃搨 Get project dependencies recursively with Very Good CLI
very_good packages get -r

# Or get project dependencies manually
dart pub get && cd bricks/test_optimizer && dart pub get && cd ../../
  1. Run all Very Good CLI tests:
# 馃И Run Very Good CLI's unit test (from project root)
flutter test -x pull-request-only

If some tests do not pass out of the box, please submit an issue.

  1. Install your own version of Very Good CLI in your local environment:
# 馃殌 Activate your own local version of Very Good CLI
dart pub global activate --source path .

Creating a Pull Request

Before creating a Pull Request please:

  1. Fork the GitHub repository and create your branch from main:
# 馃 Branch from `main`
git branch <branch-name>
git checkout <branch-name>

Where <branch-name> is an appropriate name describing your change.

  1. Install dependencies:
# 馃搨 Get project dependencies recursively with Very Good CLI
very_good packages get -r

# Or get project dependencies manually
dart pub get && cd bricks/test_optimizer && dart pub get && cd ../../

  1. Ensure you have a meaningful semantic commit message.

  2. Add tests! Pull Requests without 100% test coverage will not be merged. If you're unsure on how to do so watch our Testing Fundamentals Course.

  3. Ensure the existing test suite passes locally:

# 馃И Run Very Good CLI's unit test (from project root)
flutter test -x pull-request-only
  1. Format your code:
# 馃Ъ Run Dart's formatter
dart format lib test
  1. Analyze your code:
# 馃攳 Run Dart's analyzer
dart analyze --fatal-infos --fatal-warnings .

Some analysis issues may be fixed automatically with:

# Automatically fix analysis issues that have associated automated fixes
dart fix --apply

馃挕 Note: Our repositories use Very Good Analysis.

  1. Create the Pull Request with a meaningful description, linking to the original issue where possible.

  2. Verify that all status checks are passing for your Pull Request once they have been approved to run by a maintainer.

馃挕 Note: While the prerequisites above must be satisfied prior to having your pull request reviewed, the reviewer(s) may ask you to complete additional work, tests, or other changes before your pull request can be accepted.