From d09dd2ed454f54c71aeef266db96e8693d420fde Mon Sep 17 00:00:00 2001 From: kat Date: Tue, 18 Jul 2023 14:34:05 -0400 Subject: [PATCH] Modify setting name and description for clarity --- MessageHandler.cpp | 2 +- Plugin.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MessageHandler.cpp b/MessageHandler.cpp index 32b97a2..2909452 100644 --- a/MessageHandler.cpp +++ b/MessageHandler.cpp @@ -14,7 +14,7 @@ const std::set arcFunctionNames = { MessageHandler::MessageHandler(Ref data) : m_data(data) { - m_shouldCleanupARCCode = BinaryNinja::Settings::Instance()->Get("objc.cleanupARCCode"); + m_shouldCleanupARCCode = BinaryNinja::Settings::Instance()->Get("workflows.objectiveC.cleanupARCCode"); std::unique_lock lock(m_stubMutex); diff --git a/Plugin.cpp b/Plugin.cpp index a9e93ce..1638293 100644 --- a/Plugin.cpp +++ b/Plugin.cpp @@ -34,12 +34,12 @@ BINARYNINJAPLUGIN bool CorePluginInit() BinaryNinja::Ref settings = BinaryNinja::Settings::Instance(); settings->RegisterGroup("objc", "Objective-C"); - settings->RegisterSetting("objc.cleanupARCCode", + settings->RegisterSetting("workflows.objectiveC.cleanupARCCode", R"({ - "title" : "ARC Cleanup", + "title" : "Hide ARC Calls", "type" : "boolean", "default" : true, - "description" : "Remove ARC related code, i.e. calls to _objc_release, _objc_retain, and other ARC functions, from ILs" + "description" : "Remove ARC-related code, e.g. calls to _objc_release, _objc_retain, and other ARC functions, in ILs" })");