Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create class types for MSVC RTTI #6218

Open
emesare opened this issue Dec 2, 2024 · 1 comment
Open

Create class types for MSVC RTTI #6218

emesare opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
Component: RTTI Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Milestone

Comments

@emesare
Copy link
Member

emesare commented Dec 2, 2024

When RTTI analysis finishes we should add another workflow that will create class types from the RTTI information. This already existed in the external plugin here however was omitted for concerns over what exactly RTTI analysis was responsible for.

After further discussion we should aim to add a disabled by default option that when enabled will automatically create class types. These class types can only really be defined with the vtables as no member fields can be inferred as constructor identification is not currently done.

After this is done we should then focus on #6217

@emesare emesare added this to the Gallifrey milestone Dec 2, 2024
@emesare emesare self-assigned this Dec 2, 2024
@xusheng6 xusheng6 added Type: Enhancement Issue is a small enhancement to existing functionality Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround labels Dec 3, 2024
@emesare
Copy link
Member Author

emesare commented Dec 5, 2024

After we do #6217 we can circle back around to this and optionally fill in member fields found inside the virtual functions, IMO this should be the users responsibility though and I am hesitant to auto create member fields, especially because ownership over them is not trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: RTTI Effort: Medium Issue should take < 1 month Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants