Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Comment for Selected Lines" does not work well #5

Open
alexrp opened this issue Mar 1, 2024 · 2 comments
Open

"Add Comment for Selected Lines" does not work well #5

alexrp opened this issue Mar 1, 2024 · 2 comments

Comments

@alexrp
Copy link

alexrp commented Mar 1, 2024

Example:

image

If I ask Sidekick to add a comment explaining the selected code, what happens is:

image

If instead I try this code:

image

I get:

image

Which seems to indicate that it is describing the code above.

I get similarly odd results anywhere I've tried this feature. Seems like it could use some love in general.

@kristopax
Copy link
Member

Hi. Thank you for reporting this. In regards to the issue of Sidekick commenting about an empty "Section of Interest", we'll try to figure out what's going on there. It's definitely not helpful.

As for the comment that seems to pertain to a different section of code, it's possible that the span of addresses from your selection includes one of the addresses associated with the other section of code. Due to a current limitation in Binary Ninja in getting the exact lines of a code selection, this can happen. Also, is it possible for you to provide another screen shot with addresses displayed? That would help us determine if that's what's going on there.

@alexrp
Copy link
Author

alexrp commented Mar 2, 2024

Sure, here's one with addresses on:

image

Also, BNDB is here if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants