Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page type patchouli:smithing does not display smithing template ingredient #754

Open
TheRealWormbo opened this issue Jul 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TheRealWormbo
Copy link
Contributor

TheRealWormbo commented Jul 10, 2024

Mod loader

Any

Minecraft version

1.20.1-.6

Patchouli version

1.20.1-84+

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

The default page type patchouli:smithing, which is supposed to display a single smithing recipe, is missing a displayed item for the template ingedient. Smithing templates are mandatory for upgrade and trimming recipes since Minecraft 1.20.

Steps to reproduce

No response

Other information

There is only a "TODO add template" comment in the vazkii.patchouli.client.book.page.PageSmithing#drawRecipe method, so it seems that functionality was intended to be added at some point, but ultimately forgotten.

@TheRealWormbo TheRealWormbo added the bug Something isn't working label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant