Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow multiblocks can cover text below the display frame #746

Open
TheRealWormbo opened this issue May 5, 2024 · 0 comments
Open

Narrow multiblocks can cover text below the display frame #746

TheRealWormbo opened this issue May 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TheRealWormbo
Copy link
Contributor

TheRealWormbo commented May 5, 2024

Mod loader

Fabric, Forge, NeoForge

Minecraft version

1.20.1

Patchouli version

1.20.1-84 (both Fabric and Forge)

Modloader version

Forge 47.1.3/47.2.0, Fabric Loader 0.15.6, Fabric API 0.92.1+1.20.1

Modpack info

(none)

The latest.log file

(n/a)

Issue description

When rendering pages of type multiblock, certain shapes cause the rendered model to extend past the bottom of the frame, covering parts of the text below.

Steps to reproduce

  1. Define a multiblock that is 1 block wide in one direction and several blocks wide in the other and set the bottom outer blocks to any visible block type.
  2. Display that multiblock in a book entry with text. As the render rotates, the outer blocks start covering the text.

(The multiblock can be defined inline on the page.)

Other information

Originally reported as VazkiiMods/Botania#4183, but this is really a Patchouli problem:
Example with the Botania Alfheim Portal multiblock

@TheRealWormbo TheRealWormbo added the bug Something isn't working label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant